Hello!
This week I added initial implementations for the following visitor:
incorrect_infinite_range
Made the additions necessary so that the parser is compatible with ASTBase also:
ErrorExp and
ErrorStatement and completed a pull request
fixing a location issue
Since the latest pull requests were merged into dmd, I could run tests and ran into this
situation:
Let's consider this code
static class C
{
// ...
final void foo() { ... }
// ...
}
So in D-Scanner we have a check that warns against redundant usage of final
keyword.
Final
is indeed redundant with static methods, but with the current D-Scanner implementation,
in the example above the usage of final
is not signaled, while with my implementation it is.
I would have a question here, and that would be if I should stick 100% with the current behavior
of D-Scanner, or if I should update the behavior, as I would say is the case here, and probably
similar situations will arise in the future.