http://d.puremagic.com/issues/show_bug.cgi?id=1480

           Summary: std.stream throws the new override warning all over the
                    place
           Product: D
           Version: 2.004
          Platform: PC
        OS/Version: Windows
            Status: NEW
          Severity: critical
          Priority: P2
         Component: Phobos
        AssignedTo: bugzilla@digitalmars.com
        ReportedBy: spam@extrawurst.org


it is as simple as that, just import the std.stream module and compile with warnings enabled then the new override warning is thrown hundreds of times:

[CODE]
import std.stream;

void main()
{}
[/CODE]

this is very annoying as i always have warnings turned on.


-- 

http://d.puremagic.com/issues/show_bug.cgi?id=1480





------- Comment #1 from ddparnell@bigpond.com  2007-10-16 21:48 -------
Messages like ...

phobos\std\stream.d(1942): function std.stream.File.size overrides base class function std.stream.Stream.size, but is not marked with 'override'

This is a major showstopper for me too as I always use the -w switch.


-- 

http://d.puremagic.com/issues/show_bug.cgi?id=1480


braddr@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #2 from braddr@puremagic.com  2007-10-17 00:17 -------
Whoops, missed that one as it's win32 only (and most of my development is on linux).  The fix is checked in to the 2.x branch for the next release.

I dunno that I'd call it a show stopper, since it's trivial to edit the .d file, or stop compiling with warnings.  Show stoppers are generally reserved for problems that can't be worked around.  Either way, the fix is lined up now.


-- 

On Wed, 17 Oct 2007 05:17:30 +0000 (UTC), d-bugmail@puremagic.com wrote:

> http://d.puremagic.com/issues/show_bug.cgi?id=1480
> 
> braddr@puremagic.com changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|NEW                         |ASSIGNED
> 
> ------- Comment #2 from braddr@puremagic.com  2007-10-17 00:17 -------
> Whoops, missed that one as it's win32 only (and most of my development is on linux).  The fix is checked in to the 2.x branch for the next release.
> 
> I dunno that I'd call it a show stopper, since it's trivial to edit the .d file, or stop compiling with warnings.  Show stoppers are generally reserved for problems that can't be worked around.  Either way, the fix is lined up now.

Ok, so "showstopper" is being a tad dramatic :-)

But house rules include ...

  "Thou shalt not mess with phobos source code"

and

  "A 'warning' is a warning, so fix it."

-- 
Derek
(skype: derek.j.parnell)
Melbourne, Australia
17/10/2007 4:06:24 PM

http://d.puremagic.com/issues/show_bug.cgi?id=1480


spam@extrawurst.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spam@extrawurst.org




------- Comment #3 from spam@extrawurst.org  2007-11-02 17:14 -------
did i miss something ? it is not fixed in the 2.007 release is it ?


-- 

http://d.puremagic.com/issues/show_bug.cgi?id=1480





------- Comment #4 from braddr@puremagic.com  2007-11-03 16:30 -------
It's fixed, just missing from the change log (mail sent to walter to get that fixed already).  If there's an override annotation that's missing still, shout.


-- 

http://d.puremagic.com/issues/show_bug.cgi?id=1480


spam@extrawurst.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #5 from spam@extrawurst.org  2007-11-03 21:14 -------
i am sorry, my bad, as far as i can see it is solved in dmd2.007


--