Thread overview | |||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
|
October 28, 2009 [Issue 3446] New: Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
http://d.puremagic.com/issues/show_bug.cgi?id=3446 Summary: Rename float.min to float.min_normal Product: D Version: 2.035 Platform: Other OS/Version: Windows Status: NEW Keywords: patch Severity: enhancement Priority: P2 Component: DMD AssignedTo: nobody@puremagic.com ReportedBy: clugdbug@yahoo.com.au --- Comment #0 from Don <clugdbug@yahoo.com.au> 2009-10-28 03:18:15 PDT --- Discussion: http://www.digitalmars.com/webnews/newsgroups.php?art_group=digitalmars.D&article_id=99283 Patch: About as simple as you can possibly imagine. idgen.c, line 116 { "infinity" }, { "dig" }, { "epsilon" }, + { "min_normal" }, { "mant_dig" }, { "max_10_exp" }, mtype.c, line 1989: else if (ident == Id::min) { switch (ty) { case Tint8: ivalue = -128; goto Livalue; case Tuns8: ivalue = 0; goto Livalue; case Tint16: ivalue = -32768; goto Livalue; case Tuns16: ivalue = 0; goto Livalue; case Tint32: ivalue = -2147483647L - 1; goto Livalue; case Tuns32: ivalue = 0; goto Livalue; case Tint64: ivalue = (-9223372036854775807LL-1LL); goto Livalue; case Tuns64: ivalue = 0; goto Livalue; case Tbool: ivalue = 0; goto Livalue; case Tchar: ivalue = 0; goto Livalue; case Twchar: ivalue = 0; goto Livalue; case Tdchar: ivalue = 0; goto Livalue; + } + } + else if (ident == Id::min_normal) + { + switch (ty) + { case Tcomplex32: -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
October 28, 2009 [Issue 3446] Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
Posted in reply to Don | http://d.puremagic.com/issues/show_bug.cgi?id=3446 Leandro Lucarella <llucax@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |llucax@gmail.com --- Comment #1 from Leandro Lucarella <llucax@gmail.com> 2009-10-28 09:04:33 PDT --- It would be too much trouble to publish the patches using diff -u and attaching them as a file? This way I can test them more easily. Thank you. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
October 28, 2009 [Issue 3446] Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
Posted in reply to Don | http://d.puremagic.com/issues/show_bug.cgi?id=3446 --- Comment #2 from Don <clugdbug@yahoo.com.au> 2009-10-28 09:10:46 PDT --- Created an attachment (id=483) Patch against DMD2 svn221 For Leandro. Walter normally puts the patches in manually, line-by-line, for tiny patches like this, so I've given up attaching patch files. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
October 28, 2009 [Issue 3446] Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
Posted in reply to Don | http://d.puremagic.com/issues/show_bug.cgi?id=3446 --- Comment #3 from Leandro Lucarella <llucax@gmail.com> 2009-10-28 11:10:09 PDT --- Thanks! I guess Walter will be able to do the modifications manually seeing the diff-generated patch anyway, and people wanting to test the patches before they actually committed can do it easily too =) -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
November 04, 2009 [Issue 3446] Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
Posted in reply to Don | http://d.puremagic.com/issues/show_bug.cgi?id=3446 Walter Bright <bugzilla@digitalmars.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@digitalmars.com --- Comment #4 from Walter Bright <bugzilla@digitalmars.com> 2009-11-04 11:55:11 PST --- Discussion on one page: http://www.digitalmars.com/d/archives/digitalmars/D/Mini_proposal_rename_float.min_to_float.min_normal_99283.html -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
November 04, 2009 [Issue 3446] Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
Posted in reply to Don | http://d.puremagic.com/issues/show_bug.cgi?id=3446 --- Comment #5 from Walter Bright <bugzilla@digitalmars.com> 2009-11-04 12:04:10 PST --- I'll put it in, but will leave .min working for now for backwards compatibility. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
November 04, 2009 [Issue 3446] Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
Posted in reply to Don | http://d.puremagic.com/issues/show_bug.cgi?id=3446 --- Comment #6 from Don <clugdbug@yahoo.com.au> 2009-11-04 12:06:35 PST --- (In reply to comment #5) > I'll put it in, but will leave .min working for now for backwards compatibility. Awesome! -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
November 05, 2009 [Issue 3446] Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
Posted in reply to Don | http://d.puremagic.com/issues/show_bug.cgi?id=3446 --- Comment #7 from Leandro Lucarella <llucax@gmail.com> 2009-11-05 06:24:20 PST --- The documentation was updated in http://www.dsource.org/projects/phobos/changeset/1321. But there is no mention to .min being deprecated (because it is, right?). I think the documentation should reflect that. Thanks. Other related commits: http://www.dsource.org/projects/phobos/changeset/1322 http://www.dsource.org/projects/dmd/changeset/238 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
November 06, 2009 [Issue 3446] Rename float.min to float.min_normal | ||||
---|---|---|---|---|
| ||||
Posted in reply to Don | http://d.puremagic.com/issues/show_bug.cgi?id=3446 Walter Bright <bugzilla@digitalmars.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #8 from Walter Bright <bugzilla@digitalmars.com> 2009-11-06 11:35:20 PST --- Fixed dmd 2.036 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- |
Copyright © 1999-2021 by the D Language Foundation