On Sunday, 28 June 2015 at 10:06:20 UTC, Joakim wrote:
> On Sunday, 28 June 2015 at 09:55:53 UTC, Vladimir Panteleev wrote:
>> On Sunday, 28 June 2015 at 09:46:45 UTC, rsw0x wrote:
>>> looks like this commit more than doubled the size of hello world
>>>
>>> https://github.com/D-Programming-Language/phobos/pull/3443
>>
>> Woah. Why would removing an import increase the filesize?
>
> I didn't get that either, maybe he meant the PR that yours fixed is the one that doubled it?

No, he's right. Removing the import doubled the filesize of a helloworld binary.

> On Sunday, 28 June 2015 at 09:58:35 UTC, Vladimir Panteleev wrote:
>> On Sunday, 28 June 2015 at 09:27:56 UTC, Joakim wrote:
>>> Another check that would be more worthwhile but harder to measure would be speed of compilation of druntime/phobos, especially since speed of compilation is considered a key selling point of D.  Harder to measure because it depends on what else is going on on that machine, but with some care and enough samples, you could get something representative.
>>
>> Compilation/linking time are measured for the sample programs.
>
> Yeah, I saw that, but I was talking about adding a github check for D PRs and how they affect compilation speed, especially for dmd PRs.  Druntime/Phobos and eventually ddmd may not be the best way to check it, but it's the closest lamppost. ;)
>
> Smaller binary size is nice to have, but not that important, especially since we've been neglecting it for some time now.
>
> Compilation speed is something we're always trumpeting, we better track it.

It's not really possible to meaningfully track such an inaccurate statistic on a per-commit basis. See it yourself - select one of the time tests in AWSY and zoom in. It works in aggregate - when zoomed out, you see the medians and can get the general big picture. But when comparing any two commits directly, there is just too much error.

On Sunday, 28 June 2015 at 10:06:20 UTC, Joakim wrote:
> On Sunday, 28 June 2015 at 09:55:53 UTC, Vladimir Panteleev wrote:
>> On Sunday, 28 June 2015 at 09:46:45 UTC, rsw0x wrote:
>>> looks like this commit more than doubled the size of hello world
>>>
>>> https://github.com/D-Programming-Language/phobos/pull/3443
>>
>> Woah. Why would removing an import increase the filesize?
>
> I didn't get that either, maybe he meant the PR that yours fixed is the one that doubled it?

it's the PR that's linked when I zoomed in on executable size in 'Hello World'. It's not visible at first(I guess because the PR is so new?,) you have to zoom in once or twice.

I guess a picture is worth a thousand words. http://i.imgur.com/p0r5tFH.png

On Sunday, 28 June 2015 at 10:11:08 UTC, Vladimir Panteleev wrote:
> No, he's right. Removing the import doubled the filesize of a helloworld binary.

Ah, I didn't want to download the full 90 MBs graph data again to see it.  Yes, I see it now.

>> On Sunday, 28 June 2015 at 09:58:35 UTC, Vladimir Panteleev wrote:
> It's not really possible to meaningfully track such an inaccurate statistic on a per-commit basis. See it yourself - select one of the time tests in AWSY and zoom in. It works in aggregate - when zoomed out, you see the medians and can get the general big picture. But when comparing any two commits directly, there is just too much error.

Seems pretty stable to me, almost as much as file size even, which is surprising.  I did note that you'd have to be careful to measure it on a relatively unloaded machine and average multiple runs, but I don't see why it couldn't be done.  There is some variability on some of those, but as long as you didn't overreact on small changes and maybe compared one PR's results to averaged past data, ie over multiple PRs, as the baseline, it should work.

On Sunday, 28 June 2015 at 10:37:15 UTC, Joakim wrote:
> On Sunday, 28 June 2015 at 10:11:08 UTC, Vladimir Panteleev wrote:
>> No, he's right. Removing the import doubled the filesize of a helloworld binary.
>
> Ah, I didn't want to download the full 90 MBs graph data again to see it.  Yes, I see it now.

It's only about 5 MB compressed. Some browsers show the decompressed size.