http://d.puremagic.com/issues/show_bug.cgi?id=4363

           Summary: std.algorithm.Until is not a forward range
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Phobos
        AssignedTo: nobody@puremagic.com
        ReportedBy: philippe.sigaud@gmail.com


--- Comment #0 from Philippe Sigaud <philippe.sigaud@gmail.com> 2010-06-22 10:56:46 CEST ---
As of 2.047, to be a forward range one has to have a .save() method.

std.algorithm.Until does not have one, but should be a forward range.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4363


yebblies <yebblies@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yebblies@gmail.com


--- Comment #1 from yebblies <yebblies@gmail.com> 2010-06-22 23:57:03 PDT ---
I've also noticed randomCover has the same problem.  Maybe rather than create a separate bug report this one could list the ranges in phobos that need a '@property typeof(this) save() { return this; }' added?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4363



--- Comment #2 from Philippe Sigaud <philippe.sigaud@gmail.com> 2010-06-23 21:43:43 CEST ---
(In reply to comment #1)

Yeah, I meant to scan std.algo but one of my daughters got sick and... well.

You could list other ranges that have the same problem, but in this case I need to change the bug report's title.

...

OK, done. Go wild.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4363


yebblies <yebblies@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Some std.algorithm ranges   |Some phobos ranges are not
                   |are not forward ranges (but |forward ranges (but should
                   |should be)                  |be)


--- Comment #3 from yebblies <yebblies@gmail.com> 2010-06-23 22:15:25 PDT ---
std.numeric: GapWeightedSimilarityIncremental
std.random: LinearCongruentialEngine, MersenneTwisterEngine, RandomCover,
RandomSample
std.range: Radial, Repeat, Cycle, Recurrence, FrontTransversal, Transversal
std.regex: Regex
std.regexp: Splitter
std.algorithm: Filter, Splitter, Uniq, Group, Until, SetUnion, SetIntersection,
SetDifference, SetSymmetricDifference
std.container: SList(T).Range

This list is of any structs that define popFront and do not define save, and seem to support copying.  I've excluded any types with allocated storage, unless they define a copy constructor.  I've also excluded any that are obviously designed to be input ranges (have a File handle etc) but a couple may have slipped through.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4363



--- Comment #4 from yebblies <yebblies@gmail.com> 2010-06-23 22:18:24 PDT ---
Changed the title to reflect that this report covers all of phobos, not just std.algorithm.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4363



--- Comment #5 from yebblies <yebblies@gmail.com> 2010-06-24 01:54:48 PDT ---
According to David Simcha's commcent in bug 4362, repeat and cycle have already been fixed in svn.  This leaves:

std.numeric: GapWeightedSimilarityIncremental
std.random: LinearCongruentialEngine, MersenneTwisterEngine, RandomCover,
RandomSample
std.range: Radial, Recurrence, FrontTransversal, Transversal
std.regex: Regex
std.regexp: Splitter
std.algorithm: Filter, Splitter, Uniq, Group, Until, SetUnion, SetIntersection,
SetDifference, SetSymmetricDifference
std.container: SList(T).Range

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4363


yebblies <yebblies@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Jesse.K.Phillips+D@gmail.co
                   |                            |m


--- Comment #6 from yebblies <yebblies@gmail.com> 2010-07-15 19:40:15 PDT ---
*** Issue 4467 has been marked as a duplicate of this issue. ***

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4363


David Simcha <dsimcha@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |dsimcha@yahoo.com
         Resolution|                            |FIXED


--- Comment #7 from David Simcha <dsimcha@yahoo.com> 2010-08-14 21:05:03 PDT ---
Fixed SVN.  (At least I think I got all of them.)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------