http://d.puremagic.com/issues/show_bug.cgi?id=4398



--- Comment #20 from Jacob Carlborg <doob@me.com> 2010-10-10 06:42:16 PDT ---
(In reply to comment #19)
> (In reply to comment #18)
> > (In reply to comment #17)
> > > I don't think that the attached patches are correct. As far as I can see
> > > looking at the makefiles, deh.c is used on windows and deh2.d is used on posix.
> > > So _d_throw in deh2.d would be extern (C) or extern (Windows) (doesn't really
> > > matter) then _d_throw in deh.c would still be __stdcall.
> > 
> > Sorry, extern (C) or extern (System)
> 
> Sorry, I should have mentioned: I tested on linux and I used tango (which has the same files). So the deh.c should not have been used at all, right?
> 
> --Marenz

Correct, deh.c should not have been used at all. But tango should not build that file when building on linux.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4398


Johannes Pfau <johannespfau@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #685 is|0                           |1
           obsolete|                            |


--- Comment #21 from Johannes Pfau <johannespfau@gmail.com> 2010-10-10 08:51:57 PDT ---
Created an attachment (id=780)
Yet another druntime patch

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4398



--- Comment #22 from Johannes Pfau <johannespfau@gmail.com> 2010-10-10 08:54:35 PDT ---
True, deh.c should stay as it is. My understanding of C and druntime wasn't that great at the time I wrote the patch. I'll attach an updated patch, but Walter will likely have to look into this again anyway when he starts to implement support for shared libraries on Linux. This patch alone won't help much there though, it's just the first step for shared library support, there are way bigger issues.

Tango and phobos1 need to be patched as well. I haven't looked into tango, but if the code is the same as the druntime code the deh2.d patch should work. I tested the patched compiler and druntime on Linux back then and I'm sure it worked.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4398


Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@digitalmars.com


--- Comment #23 from Walter Bright <bugzilla@digitalmars.com> 2010-10-24 21:37:52 PDT ---
deh.c is Windows only. It is in C because it interacts with all the complex Windows header definitions for Windows SEH that have not been ported to D. D's eh mechanism on Windows is layered on top of Windows SEH.

For other platforms, deh2.d is used instead, as D uses its own invented exception handling mechanism. (It is not compatible with the C++ eh ELF mechanism.)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4398



--- Comment #24 from Walter Bright <bugzilla@digitalmars.com> 2010-10-24 21:46:02 PDT ---
No need to mess with LONGJMP_MANGLE_NAME and CPP_LONGJMP_MANGLE_NAME as they are for the C++ compiler. They are never referenced by dmd, and do not appear in Phobos.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4398



--- Comment #25 from Walter Bright <bugzilla@digitalmars.com> 2010-10-24 22:19:49 PDT ---
Compiler: http://www.dsource.org/projects/dmd/changeset/730 Phobos1: http://www.dsource.org/projects/phobos/changeset/2114 Druntime: http://www.dsource.org/projects/druntime/changeset/407

Note that I left the old _d_throw@8 in Phobos1 for binary compatibility with libraries that link with Phobos. I suppose Tango will have to do the same (provide the new entry point, as dmd1 now calls the new entry point).

Eventually, that entry point will be removed.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4398


Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------