[Issue 3632] modify float is float to do a bitwise compare (page 3)

February 16, 2012

[Issue 3632] modify float is float to do a bitwise compare

Posted by yebblies
in reply to Steven Schveighoffer

Permalink

yebblies

Posted in reply to Steven Schveighoffer

Permalink

http://d.puremagic.com/issues/show_bug.cgi?id=3632


yebblies <yebblies@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull
         AssignedTo|nobody@puremagic.com        |yebblies@gmail.com


--- Comment #20 from yebblies <yebblies@gmail.com> 2012-02-16 17:07:55 EST ---
New pull for this issue:

https://github.com/D-Programming-Language/dmd/pull/724

Walter, please reconsider your position - I really believe that the advantages of 'is' always being a straight bitwise comparison outweigh the downsides.  As you've pointed the inconsistency between how floats are handled with 'is' and when determining if template value parameters match, I've changed that too to make it consistent.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=3632 --- Comment #21 from bearophile_hugs@eml.cc 2012-02-16 04:44:31 PST --- (In reply to comment #20) > - I really believe that the advantages > of 'is' always being a straight bitwise comparison outweigh the downsides. This is what I was asking in the closed down issue 3981 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=3632 --- Comment #22 from yebblies <yebblies@gmail.com> 2012-02-17 00:08:26 EST --- (In reply to comment #21) > This is what I was asking in the closed down issue 3981 I know, that's why I closed issue 3981 with a comment saying that part was covered by this report... -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=3632 --- Comment #23 from github-bugzilla@puremagic.com 2012-02-17 16:40:35 PST --- Commit pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/b558967f56b3702557e5c70132e77dd05561f2e3 Merge pull request #724 from yebblies/issue3632 Issue 3632 - modify float is float to do a bitwise compare -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=3632 --- Comment #24 from Walter Bright <bugzilla@digitalmars.com> 2012-02-17 17:22:43 PST --- change reverted - does not work -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=3632 --- Comment #25 from yebblies <yebblies@gmail.com> 2012-02-18 13:36:57 EST --- New pull to revert the revert. https://github.com/D-Programming-Language/dmd/pull/730 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=3632 --- Comment #26 from github-bugzilla@puremagic.com 2012-04-27 15:06:20 PDT --- Commits pushed to master at https://github.com/D-Programming-Language/dmd https://github.com/D-Programming-Language/dmd/commit/f9c21c2a77e32d310c8cb9d6c23f517d410cbec6 Reintroduce the fix for issue 3632, without the dependency on fixing issue 1824. Revert the parts in clone.c that were commented out, so pull #387 can merge cleanly. https://github.com/D-Programming-Language/dmd/commit/5da38bd430246d82e06d5581bb15325094821ca5 Merge pull request #730 from yebblies/issue3632 Reintroduce the fix for issue 3632, without the dependency on fixing issue 1824. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=3632 --- Comment #27 from Walter Bright <bugzilla@digitalmars.com> 2012-04-27 15:43:54 PDT --- Reverted because their tests failed. -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=3632 --- Comment #28 from yebblies <yebblies@gmail.com> 2013-01-17 16:08:29 EST --- New (and hopefully last) pull https://github.com/D-Programming-Language/dmd/pull/1499 -- Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email ------- You are receiving this mail because: -------

Forums