Thread overview
[Issue 4507] New: use spellchecker when override function doesn't override anything
Jul 26, 2010
Trass3r
Jul 26, 2010
Trass3r
Mar 12, 2012
Walter Bright
July 26, 2010
http://d.puremagic.com/issues/show_bug.cgi?id=4507

           Summary: use spellchecker when override function doesn't
                    override anything
           Product: D
           Version: D1 & D2
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: diagnostic
          Severity: normal
          Priority: P2
         Component: DMD
        AssignedTo: nobody@puremagic.com
        ReportedBy: mrmocool@gmx.de


--- Comment #0 from Trass3r <mrmocool@gmx.de> 2010-07-26 07:17:49 PDT ---
interface Foo
{
    void tranform();
}

class Bar : Foo
{
    override void transform()
    {
    }
}

override.d(8): Error: function override.Bar.transform does not override any
function

Omitting override gives the equally useless message:
override.d(6): Error: class override.Bar interface function Foo.tranform isn't
implemented

I once spent a lot of time to figure out the cause of this error because the
missing 's' is hardly noticeable.
Why doesn't dmd use its spellchecker to help here?


Similar problem is if the name is correct but parameters or other things don't match. In this case dmd should also suggest something like "did you mean transform(f) instead of transform(const f)" or whatever.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
July 26, 2010
http://d.puremagic.com/issues/show_bug.cgi?id=4507



--- Comment #1 from Trass3r <mrmocool@gmx.de> 2010-07-26 07:44:36 PDT ---
k, had a quick look, obviously FuncDeclaration::findVtblIndex would need to be modified.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
March 12, 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4507



--- Comment #2 from github-bugzilla@puremagic.com 2012-03-12 00:40:47 PDT ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/945772cd984d7f6c469ffcbedb0a33711e5d3471 fix issue 4507

https://github.com/D-Programming-Language/dmd/commit/641cc658ef2b11d44b3c3239378be6d8afbd1d09 Merge pull request #801 from dawgfoto/fix4507

fix issue 4507

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
March 12, 2012
http://d.puremagic.com/issues/show_bug.cgi?id=4507


Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull
             Status|NEW                         |RESOLVED
                 CC|                            |bugzilla@digitalmars.com
         Resolution|                            |FIXED
           Severity|normal                      |enhancement


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------