On Thursday, 28 May 2020 at 17:41:25 UTC, Adam D. Ruppe wrote:
> On Wednesday, 27 May 2020 at 12:55:07 UTC, WebFreak001 wrote:
>> [...]
>
> So I'm gonna integrate at least some of this tonight or tomorrow... but probably not all of it.
>
>> - Prepended the symbol kind as text to the title ("Function")
>
> like idk the value of this.

idk either but the ddox page renders it. Just like "Class", "Struct", "Alias", "Interface", "Template", "Mixin Template", "Function", "Variable", "Enum"

>> - Disable Line numbers by default for short code (<15 lines)
>
> fun fact i think right now my limit is 7 lines...
>
>> - Delete & Disable the dynamic style (resize style)
>
> I know I put that in for a reason but forgot what it was... what was it breaking for you?

it made the overload tabs smaller than max width. Also resizing with JS is pretty inefficient, better move it to CSS.

>
>>   max-width: unset !important;;
>
> these max widths too btw were there to keep the main content from going wide just because of some long line in an example.

I wrapped the whole code block in a new div, which made the max-width inside the code blocks no longer necessary I think. At least the parent div should now get that max width if it was important.

> I gotta extract the diffs and put it in here to try on the sdpy docs.
>
>> .documentation-comment p {
>>   hyphens: auto;
>> }
>
> i hate hyphens tho

I don't :p

On Wednesday, 27 May 2020 at 12:55:07 UTC, WebFreak001 wrote:
> - In the small overloads buttons (.overloads>li .overload-signature), remove all parameter type qualifiers and default values, only keep names and basic types

I'm not sure I can do this without more invasive changes to the generator.

But I did most the changes here you can refresh to reload:

http://dpldocs.info/experimental-docs/arsd.simpledisplay.SimpleWindow.this.1.html

only regenerated sdpy dox with the new html btw.

I'm pretty sure I missed a few spots applying your new stuff, and I rejected a few pieces. But.... I don't hate it so far.


> Make link for `const(char)[]` as type explaining that it works with strings and char arrays. Also embed the graph from and link to https://dlang.org/spec/const3.html#implicit_qualifier_conversions
>
> Make link for `size_t` and `ptrdiff_t` as type explaining that it's an (unsigned) integer type, commonly (u)int or (u)long with link to https://dlang.org/spec/type.html#size_t

Once upon a time, I was going to do a bunch of links like this. Never actually got around to.... almost any of them. But i like the idea.


I still need to check it across more pages and other browsers before going all the way. But I think this is gonna be ok.

I still don't love the "Example" header - not all those are examples (notably view source!). So might tweak that.

BTW on the hard questions:

http://dpldocs.info/experimental-docs/arsd.cgi.Cgi.this.2.html

the delegates in there always look bleh. idk.

On Friday, 29 May 2020 at 02:12:34 UTC, Adam D. Ruppe wrote:
> On Wednesday, 27 May 2020 at 12:55:07 UTC, WebFreak001 wrote:
>> - In the small overloads buttons (.overloads>li .overload-signature), remove all parameter type qualifiers and default values, only keep names and basic types
>
> I'm not sure I can do this without more invasive changes to the generator.

Yeah but for some functions I think it could make it much more readable if you did do that. You could use libdparse and try to parse that declaration as variable definition + trailing semicolon to exactly find the parts of the expression.

> But I did most the changes here you can refresh to reload:
>
> http://dpldocs.info/experimental-docs/arsd.simpledisplay.SimpleWindow.this.1.html
>
> only regenerated sdpy dox with the new html btw.
>
> I'm pretty sure I missed a few spots applying your new stuff, and I rejected a few pieces. But.... I don't hate it so far.

meh, still 1.1rem font size :p

can you maybe comment on the overload changes a little? Especially keeping the margins around the whole block and keeping the ridge border + 2px borders between buttons.

>> Make link for `const(char)[]` as type explaining that it works with strings and char arrays. Also embed the graph from and link to https://dlang.org/spec/const3.html#implicit_qualifier_conversions
>>
>> Make link for `size_t` and `ptrdiff_t` as type explaining that it's an (unsigned) integer type, commonly (u)int or (u)long with link to https://dlang.org/spec/type.html#size_t
>
> Once upon a time, I was going to do a bunch of links like this. Never actually got around to.... almost any of them. But i like the idea.

Maybe it's worth writing that down somewhere in some issue tracker or todo comment

> I still need to check it across more pages and other browsers before going all the way. But I think this is gonna be ok.
>
> I still don't love the "Example" header - not all those are examples (notably view source!). So might tweak that.

I was just thinking of some content to fill there, might be worth putting anything else in there too. In the C# docs it says "C#" because .NET can be used from multiple languages.

> BTW on the hard questions:
>
> http://dpldocs.info/experimental-docs/arsd.cgi.Cgi.this.2.html
>
> the delegates in there always look bleh. idk.

hm seems ok imo


Also about the prefix with "Function" part again: In the sidebar you already have the headers for these things, why not use those?

Found another small area for improvement on enum members:

.enum-members {
  min-width: 60%;
  margin: auto;
}

/* just added .enum-members .enum-member-name to the inline code definition */
tt.D, .inline-code, .parameter-descriptions .parameter-name, .enum-members .enum-member-name {
  color: black;
  font-weight: 500;
  background-color: #f2f2f2;
  padding: 0px 0.5ex;
  border-radius: 2px;
}

.enum-member .enum-attributes:empty {
  display: none;
}

.enum-members td,
.enum-members th {
  padding: 0.25em 0.5em;
}

.enum-members th {
  background-color: #e8e8e8;
  color: black;
}

.enum-members tr.enum-member > td:nth-child(2) > div:only-child:empty:before {
  display: inline;
  content: "n/a";
  color: rgba(0, 0, 0, 0.4);
  font-style: italic;
}


Before: https://i.imgur.com/zjHPMWI.png
After: https://i.imgur.com/twNnJxd.png

On Friday, 29 May 2020 at 07:39:59 UTC, WebFreak001 wrote:
> meh, still 1.1rem font size :p

lol i commented it out.... then copy/pasted it back in right after without realizing it.

So I thought I removed it then was like "huh that actually still looks pretty good" and was gonna live with it.

But idk I really prefer the body text standing out a little but i might just hack that for me. Regardless it was just a mistake so changed it now.


Just... I seriously hate it. And changing my browser's default font size breaks other sites (I know it isn't supposed to but like i have to use garbage sometimes). Like now forum.dlang.org is killer cuz it does `font-size: 120%` like so many other sites. ugh ugh ugh.

whatever i'll hack it somehow on my end.


> can you maybe comment on the overload changes a little? Especially keeping the margins around the whole block and keeping the ridge border + 2px borders between buttons.

i copy/pasted it in the file but it was overridden somewhere else. my css is such a ball of spaghetti so getting your css patch actually applied was kinda a mess (actually if you can send me a patch file instead of blocks like this it would be easier - I don't preprocess the css at all so just downloading it from the site and running diff over it would be good enough).

try it now anyway

> I was just thinking of some content to fill there, might be worth putting anything else in there too. In the C# docs it says "C#" because .NET can be used from multiple languages.

Yes, I put the language in a little tag on teh upper right.

here for example:
http://dpldocs.info/experimental-docs/arsd.simpledisplay.html#windows-tips

So maybe I can move that tag into there... I'll play with it.


> Also about the prefix with "Function" part again: In the sidebar you already have the headers for these things, why not use those?

I'm not even sure I like that separation in the sidebar. I kinda feel it is less usable than a simple alphabetic listing. I've considered removing it many times.

Similarly, I kinda hate the grey background on inline code (tt.D, .inline-code, etc). I stole that from Stack Overflow I think to replace simple bolding, like the ddoc Phobos style does (and I kept that on enum members and function params)... but I kinda prefer the bolding. Just it was a bit loud inline. But for headers  like enum values and param names, I definitely prefer it to the background.


>   content: "n/a";

also not in love with this.... but i don't hate it either so idk. maybe just "undocumented" would be better

ima play some more

On Friday, 29 May 2020 at 07:39:59 UTC, WebFreak001 wrote:
> Yeah but for some functions I think it could make it much more readable if you did do that. You could use libdparse and try to parse that declaration as variable definition + trailing semicolon to exactly find the parts of the expression.

LOL I just went to look at the source to confirm what I was already doing and check this out:

void putSimplfiedArgs(T)(MyOutputRange output, const T decl) {
        // FIXME: do NOT show default values here
        if(decl.parameters)
                output.putTag(toHtml(decl.parameters).source);
}


So yeah it is just a matter of making it work. Probably doing foreach param instead of using the array would be good enough since it is already parsed.

On Friday, 29 May 2020 at 07:39:59 UTC, WebFreak001 wrote:
> meh, still 1.1rem font size :p


So after removing this some of the irc gang said they don't like how big the sidebar nav is.

It is the same as it was before.... but with the main body shrunk and with the different fonts they look out of proportion.

So my options seem to be:

1) tell users to deal with it 8)

2) change the nav font to match the body font. That's actually the way I used to do it but someone previously thought the code font looked better so I changed it... hesitant to change it back since I'm trying to please everyone.

3) Make the nav text a bit smaller, like 0.9rem or whatever.

4) put my precious 1.1rem back.


What's your view?

On Friday, 29 May 2020 at 21:12:18 UTC, Adam D. Ruppe wrote:
> What's your view?

whoops your old message mentioned the font and i didn't apply it.

so let's see:

http://dpldocs.info/experimental-docs/arsd.cgi.Cgi.html

i think that's p ok, maybe because it uses the roboto the people who wanted it changed will like this too.

On Monday, 25 May 2020 at 13:56:10 UTC, WebFreak001 wrote:
> as some of you might know, there are 2 versions of the official phobos documentation:
>
> ddoc based (https://dlang.org/phobos/index.html)
> ddox based (https://dlang.org/library/index.html)
>

ddox because it also adds documentation for the compiler lmao.

The Dlang installer for macOS is very nice because it brings an offline copy of the documentation. I would suggest making it load CSS fonts asynchronously, instead of blocking page navigation and page render until a font times out.

On Friday, 29 May 2020 at 21:12:18 UTC, Adam D. Ruppe wrote:
> On Friday, 29 May 2020 at 07:39:59 UTC, WebFreak001 wrote:
>> meh, still 1.1rem font size :p
>
>
> So after removing this some of the irc gang said they don't like how big the sidebar nav is.
>
> It is the same as it was before.... but with the main body shrunk and with the different fonts they look out of proportion.
>
> So my options seem to be:
>
> 1) tell users to deal with it 8)
>
> 2) change the nav font to match the body font. That's actually the way I used to do it but someone previously thought the code font looked better so I changed it... hesitant to change it back since I'm trying to please everyone.
>
> 3) Make the nav text a bit smaller, like 0.9rem or whatever.
>
> 4) put my precious 1.1rem back.
>
>
> What's your view?

hm one suggestion I have: change the width:70ch to width:78ch (3 alphabets) to make it look more fitting :p If it was 70ch on 1.1rem before, that makes 77 units which are 77ch on 1rem. 78ch just to make it align with alphabets because everyone measures text length in alphabets (26 chars) :p

Also about the CSS mess: I'm not changing the CSS actually, I use the firefox stylesheet editor which just appends one CSS file to the end. So if you copy paste my CSS definitions to the very end of your CSS file it would work as expected, however actually merging them properly is better maintenance-wise.