Thread overview
[Issue 8323] New: std.string.chompPrefix does not handle varying string types properly
Jun 30, 2012
Jonathan M Davis
[Issue 8323] std.string.chompPrefix does not handle differing string types properly
Jul 01, 2012
Jonathan M Davis
Jul 09, 2012
Jonathan M Davis
June 30, 2012
http://d.puremagic.com/issues/show_bug.cgi?id=8323

           Summary: std.string.chompPrefix does not handle varying string
                    types properly
           Product: D
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Phobos
        AssignedTo: nobody@puremagic.com
        ReportedBy: jmdavisProg@gmx.com


--- Comment #0 from Jonathan M Davis <jmdavisProg@gmx.com> 2012-06-30 00:14:27 PDT ---
This fails

assert(equal(chompPrefix("\uFF28el\uFF4co", "\uFF28el\uFF4co"w), ""));

This because chompPrefix is assuming that the two strings that it's given have the same character type even though it's templated to take two completely different character types.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
July 01, 2012
http://d.puremagic.com/issues/show_bug.cgi?id=8323



--- Comment #1 from Jonathan M Davis <jmdavisProg@gmx.com> 2012-07-01 01:44:56 PDT ---
https://github.com/D-Programming-Language/phobos/pull/655

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
July 09, 2012
http://d.puremagic.com/issues/show_bug.cgi?id=8323



--- Comment #2 from github-bugzilla@puremagic.com 2012-07-08 20:16:53 PDT ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/6203835e5d699f7a37c16625db0776870532761a Fix for issue# 8323.

I decided to improve the documentation for some of std.string's functions and ended up optimizing their implementations as well (I benchmarked the new versions against the old versions, so they should definitely be faster). I also ran into bug# 8323, so I fixed it as well.

https://github.com/D-Programming-Language/phobos/commit/8c747b0abac930c29cace48c9ca0fe48c04e628e Merge pull request #655 from jmdavis/string

Fix for issue# 8323.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
July 09, 2012
http://d.puremagic.com/issues/show_bug.cgi?id=8323



--- Comment #3 from github-bugzilla@puremagic.com 2012-07-08 20:20:02 PDT ---
Commit pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/5cc381c00dc0fca33850e424ba9a0c1e13c16bbe Added fix for issue# 8323 to changelog.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
July 09, 2012
http://d.puremagic.com/issues/show_bug.cgi?id=8323


Jonathan M Davis <jmdavisProg@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------