http://d.puremagic.com/issues/show_bug.cgi?id=5587



--- Comment #9 from kennytm@gmail.com 2011-07-18 09:06:18 PDT ---
Created an attachment (id=1009)
Add __LINE__ to the unittest's uniqueId

If the purpose is only let the user identify which line the unittest is on, adding the __LINE__ to its uniqueId is enough.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=5587



--- Comment #10 from Andrei Alexandrescu <andrei@metalanguage.com> 2011-07-18 09:12:56 PDT ---
Very nice. Why patch and not pull request?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=5587



--- Comment #11 from kennytm@gmail.com 2011-07-18 12:02:03 PDT ---
(In reply to comment #10)
> Very nice. Why patch and not pull request?

Just to get see if this is good enough.  Anyway, DMD pull #264.

https://github.com/D-Programming-Language/dmd/pull/264

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=5587



--- Comment #12 from github-bugzilla@puremagic.com 2012-09-05 19:47:04 PDT ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/8f478ace129b50844aed91b5be82a78238cbb1dc Bug 5587: Give unit test name by __LINE__.

This commit appends 'Lxx' to the unittest's mangled name. The user can get the line number from the traceback:

5   x       0x000091c5 onAssertErrorMsg + 73
6   x       0x00009206 onUnittestErrorMsg + 26
7   x       0x00013199 _d_unittestm + 45
8   x       0x000019d7 void x.__unittest_fail(int) + 27
9   x       0x00001a0a void x.__unittestL13_1() + 46
                                        ^^^ line 13

https://github.com/D-Programming-Language/dmd/commit/d3669f79813ba314768daf43eb1bfa90dac4c4a1 Merge pull request #264 from kennytm/bug5587_unittestWithLine

Bug 5587: Give unit test name by __LINE__.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=5587


Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


--- Comment #13 from Walter Bright <bugzilla@digitalmars.com> 2012-09-05 19:50:07 PDT ---
Added patch to D1, too.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=5587



--- Comment #14 from Jonathan M Davis <jmdavisProg@gmx.com> 2012-09-05 19:53:54 PDT ---
Woohoo!

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=5587



--- Comment #15 from Andrei Alexandrescu <andrei@metalanguage.com> 2012-09-05 23:49:13 PDT ---
Could we also change Lexer::uniqueId to not append "_1" to the first symbol generated? I mean instead of "symbol_1", "symbol_2", ... it should generate "symbol", "symbol_1", ...

That way most unittests will have nicer names.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------