http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #20 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2012-12-23 15:22:56 PST ---
(In reply to comment #19)
> I have a possible fix at: https://github.com/Ingrater/druntime/tree/pull8936
> 
> As I can't reproduce the issue, I can't tell if this actually fixes the issue. It would be great if someone who can reproduce this, could check the fix and report the results.
> 
> Kind Regards
> Benjamin Thaut

I've just tried it, same results as before.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #21 from Benjamin Thaut <code@benjamin-thaut.de> 2012-12-23 15:27:12 PST ---
Could you compile the debug(PRINTF) version and post which search path is
printed to the console?
And with same results you mean it is still searching your whole C drive?

Kind Regards
Benjamin Thaut

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #22 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2012-12-23 15:30:29 PST ---
(In reply to comment #21)
> Could you compile the debug(PRINTF) version and post which search path is
> printed to the console?

Search paths: C:;C:\WINDOWS;

> And with same results you mean it is still searching your whole C drive?

Yes.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #23 from Benjamin Thaut <code@benjamin-thaut.de> 2012-12-23 15:34:50 PST ---
Where is your binary located? If you put it directly into the C:\ root then it obviously will have to search the whole C drive for pdbs.

Kind Regards
Benjamin Thaut

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #24 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2012-12-23 15:37:20 PST ---
(In reply to comment #23)
> Where is your binary located? If you put it directly into the C:\ root then it obviously will have to search the whole C drive for pdbs.
> 
> Kind Regards
> Benjamin Thaut

Why does it obviously have to search the entire drive? It doesn't do that in 2.059 and I get a nice stack trace. The whole point of that test-case is that the path the executable is located in is needlessly search for.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #25 from Benjamin Thaut <code@benjamin-thaut.de> 2012-12-23 15:40:36 PST ---
(In reply to comment #24)
> Why does it obviously have to search the entire drive? It doesn't do that in 2.059 and I get a nice stack trace. The whole point of that test-case is that the path the executable is located in is needlessly search for.

Because the documentation says so: http://msdn.microsoft.com/en-us/library/windows/desktop/ms681351%28v=vs.85%29.aspx

I also finally understood the issue. Thanks for your help. I have a fix now and will open a pull request soon.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #26 from Benjamin Thaut <code@benjamin-thaut.de> 2012-12-23 15:45:28 PST ---
(In reply to comment #24)

I just commited a fix to https://github.com/Ingrater/druntime/tree/pull8936 can you please confirm it actuall works?

Kind Regards
Benjamin Thaut

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #27 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2012-12-23 15:50:27 PST ---
(In reply to comment #26)
> (In reply to comment #24)
> 
> I just commited a fix to https://github.com/Ingrater/druntime/tree/pull8936 can you please confirm it actuall works?

Yes it works now, and the search path is now:

Search paths: C:\WINDOWS;

Thanks for your work!

Before your latest commit I was going to recommend to try making the code search the Windows folder before it searches the local path. So e.g. in that commit before where I've had:

Search paths: C:;C:\WINDOWS;

maybe the simple fix would be to put the local path last:

Search paths: C:\WINDOWS;C:;

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #28 from Benjamin Thaut <code@benjamin-thaut.de> 2012-12-23 15:54:51 PST ---
(In reply to comment #27)
> (In reply to comment #26)
> > (In reply to comment #24)
> > 
> > I just commited a fix to https://github.com/Ingrater/druntime/tree/pull8936 can you please confirm it actuall works?
> 
> Yes it works now, and the search path is now:
> 
> Search paths: C:\WINDOWS;
> 
> Thanks for your work!
> 
> Before your latest commit I was going to recommend to try making the code search the Windows folder before it searches the local path. So e.g. in that commit before where I've had:
> 
> Search paths: C:;C:\WINDOWS;
> 
> maybe the simple fix would be to put the local path last:
> 
> Search paths: C:\WINDOWS;C:;

If I understood the documentation correctly the search paths are only for pdbs that are not directly referenced from the executables. For example when you use the microsoft symbol store. Specifying the path of the executable should not be neccessary at all to get correct stack traces.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8936



--- Comment #29 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2012-12-23 15:57:38 PST ---
(In reply to comment #28)
> If I understood the documentation correctly the search paths are only for pdbs that are not directly referenced from the executables. For example when you use the microsoft symbol store. Specifying the path of the executable should not be neccessary at all to get correct stack traces.

I see. Thanks again for your time!

Could you make this a pull request so we can merge it before 2.061 release?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------