http://d.puremagic.com/issues/show_bug.cgi?id=2452

           Summary: Unimplemented method errors should show function
                    overload
           Product: D
           Version: 1.033
          Platform: PC
        OS/Version: Windows
            Status: NEW
          Keywords: diagnostic
          Severity: minor
          Priority: P2
         Component: DMD
        AssignedTo: bugzilla@digitalmars.com
        ReportedBy: fraserofthenight@gmail.com


If an interface method is not implemented in a class that implements the interface, the arguments the method takes should be shown. For example, if you have:

interface IAstVisitor {
    void visit(VarDeclaration node);
    void visit(FuncDeclaration node);
}

class AstPrinter : IAstVisitor {
    void visit(VarDeclaration node) { ... }
}

The current error message reads:
class AstPrinter interface function IAstVisitor.visit isn't implemented

It should read:
class AstPrinter interface function IAstVisitor.visit(FuncDeclaration) isn't
implemented

When you have 80 methods named "visit", telling them apart, figuring out exactly which one isn't implemented gets a bit more tricky...


-- 

http://d.puremagic.com/issues/show_bug.cgi?id=2452


Mariusz Gliwiński <alienballance@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alienballance@gmail.com


--- Comment #1 from Mariusz Gliwiński <alienballance@gmail.com> 2011-05-20 07:56:31 PDT ---
I'd like to see this in D2 as well.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=2452


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull
                 CC|                            |andrej.mitrovich@gmail.com
           Platform|x86                         |All
            Version|1.033                       |D1 & D2
         AssignedTo|nobody@puremagic.com        |andrej.mitrovich@gmail.com
         OS/Version|Windows                     |All
           Severity|minor                       |normal


--- Comment #2 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-01-20 12:12:14 PST ---
https://github.com/D-Programming-Language/dmd/pull/1523

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=2452



--- Comment #3 from github-bugzilla@puremagic.com 2013-01-20 16:12:04 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/dmd

https://github.com/D-Programming-Language/dmd/commit/89543ab82e6488f04c08d4fb4c769c861fd72c2f Fixes Issue 2452 - Better diagnostic on unimplemented interface.

https://github.com/D-Programming-Language/dmd/commit/a2d0e643285543850f6ae7087e183f7bd4184ce8 Merge pull request #1523 from AndrejMitrovic/Fix2452

Issue 2452 - Better diagnostic on unimplemented interface

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=2452


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------