http://d.puremagic.com/issues/show_bug.cgi?id=4847

           Summary: std.algorithm.topN documentation
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: websites
        AssignedTo: nobody@puremagic.com
        ReportedBy: bearophile_hugs@eml.cc


--- Comment #0 from bearophile_hugs@eml.cc 2010-09-09 13:02:12 PDT ---
This program seems correct (DMD 2.048):

import std.algorithm: topN;
void main() {
    int[] a = [10, 1, 7];
    topN(a, 10);
}


I'd like the documentation of topN to specify what does it happen when the specified 'nth' argument is bigger than the length of the given range.

And I think it's better to add an usage example of topN(r1, r2).

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4847


Andrei Alexandrescu <andrei@metalanguage.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |andrei@metalanguage.com
         AssignedTo|nobody@puremagic.com        |andrei@metalanguage.com


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4847



--- Comment #1 from github-bugzilla@puremagic.com 2013-03-04 15:39:47 PST ---
Commit pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/3d5a203323d59181e121f5536bd76aa2a29509f7 Fix Issue 4847 - std.algorithm.topN documentation

This was a quick fix so I'm doing it online.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4847


Andrei Alexandrescu <andrei@erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4847



--- Comment #2 from bearophile_hugs@eml.cc 2013-03-04 17:36:08 PST ---
Thank you. But the second part of the request is not fulfilled:

>And I think it's better to add an usage example of topN(r1, r2).<


The documentation of the second overload of TopN says:


void topN(alias less = "a < b", SwapStrategy ss = SwapStrategy.unstable,
Range1, Range2)(Range1 r1, Range2 r2);
    Stores the smallest elements of the two ranges in the left-hand range.

    Example:



Do you want me to reopen this?

(By the way, I have found an unfiled problem, topN uses uniform(), but I think
the module doesn't import std.random).

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4847


bearophile_hugs@eml.cc changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


--- Comment #3 from bearophile_hugs@eml.cc 2013-03-04 18:39:41 PST ---
OK, reopened, otherwise I will forget.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4847



--- Comment #4 from github-bugzilla@puremagic.com 2013-03-07 10:39:52 PST ---
Commit pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/29e043d4616a7d21fbdbd8102b95d01494750759 Fix Issue 4847 - std.algorithm.topN documentation

Converted unittest into an example.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=4847


Andrei Alexandrescu <andrei@erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


--- Comment #5 from Andrei Alexandrescu <andrei@erdani.com> 2013-03-07 10:41:05 PST ---
Thanks for following through. Refixed, please reopen if needed.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------