Menu
Search

Forums

Forum Index

Thread overview
Broken win32.mak in git HEAD
Jun 18, 2013
ollie
Jun 18, 2013
Andrej Mitrovic
Jun 18, 2013
James
Jun 18, 2013
ollie
Jun 18, 2013
Daniel Murphy
June 18, 2013
Gravatar of olliePosted by ollieReply
ollie
Gravatar of ollie


Reply
In the win32.mak file under the clean tag :

clean:
	$(DEL) *.obj
	$(DEL) total.sym
	$(DEL) msgs.h msgs.c
	$(DEL) elxxx.c cdxxx.c optab.c debtab.c fltables.c tytab.c
	$(DEL) impcnvtab.c
	$(DEL) id.h id.c
	$(DEL) verstr.h
	cd $(CPPUNIT)\src\cppunit
	$(MAKE) clean

"cd $(CPPUNIT)\src\cppunit" was removed but the follow on line "$(MAKE) clean" was left in.  It errors on that line and should probably be removed.

Thanks,

ollie
June 18, 2013
Gravatar of Andrej MitrovicPosted by Andrej Mitrovic
in reply to ollie		Reply
Andrej Mitrovic
Gravatar of Andrej Mitrovic
Posted in reply to ollie


Reply
On Tuesday, 18 June 2013 at 15:47:49 UTC, ollie wrote:
> In the win32.mak file under the clean tag :
>
> clean:
> 	$(DEL) *.obj
> 	$(DEL) total.sym
> 	$(DEL) msgs.h msgs.c
> 	$(DEL) elxxx.c cdxxx.c optab.c debtab.c fltables.c tytab.c
> 	$(DEL) impcnvtab.c
> 	$(DEL) id.h id.c
> 	$(DEL) verstr.h
> 	cd $(CPPUNIT)\src\cppunit
> 	$(MAKE) clean
>
> "cd $(CPPUNIT)\src\cppunit" was removed but the follow on line "$(MAKE)
> clean" was left in.  It errors on that line and should probably be removed.
>
> Thanks,
>
> ollie

It was removed together with the pull:
https://github.com/D-Programming-Language/dmd/blob/master/src/win32.mak

Perhaps you had a bad rebase locally?
June 18, 2013
Gravatar of JamesPosted by James
in reply to Andrej Mitrovic		Reply
James
Gravatar of James
Posted in reply to Andrej Mitrovic


Reply
On Tue, 18 Jun 2013 17:54:13 +0200, Andrej Mitrovic wrote:

> 
> It was removed together with the pull: https://github.com/D-Programming-Language/dmd/blob/master/src/win32.mak
> 
> Perhaps you had a bad rebase locally?

I also did a fresh clone to double check.  Same problem.
June 18, 2013
Gravatar of olliePosted by ollie
in reply to Andrej Mitrovic		Reply
ollie
Gravatar of ollie
Posted in reply to Andrej Mitrovic


Reply
On Tue, 18 Jun 2013 17:54:13 +0200, Andrej Mitrovic wrote:

> 
> It was removed together with the pull: https://github.com/D-Programming-Language/dmd/blob/master/src/win32.mak
> 
> Perhaps you had a bad rebase locally?

clean:	$(DEL) *.obj
	$(DEL) total.sym
	$(DEL) msgs.h msgs.c
	$(DEL) elxxx.c cdxxx.c optab.c debtab.c fltables.c tytab.c
		$(DEL) impcnvtab.c
	$(DEL) id.h id.c
	$(DEL) verstr.h
	$(MAKE) clean

The "$(MAKE) clean" is still in the file.  The change directory has been removed but the subsequent make clean borks because the directory it was changed to is gone now.

Thanks,

ollie
June 18, 2013
Gravatar of Daniel MurphyPosted by Daniel Murphy
in reply to ollie		Reply
Daniel Murphy
Gravatar of Daniel Murphy
Posted in reply to ollie


Reply
"ollie" <ollie@home.net> wrote in message news:kppvf4$49m$1@digitalmars.com...
> In the win32.mak file under the clean tag :
>
> "cd $(CPPUNIT)\src\cppunit" was removed but the follow on line "$(MAKE)
> clean" was left in.  It errors on that line and should probably be
> removed.
>

Yeah sorry, this was me.  I opened a pull to fix it.

https://github.com/D-Programming-Language/dmd/pull/2211