Thread overview
[Issue 10468] New: Regression (2.063): Lockstep no longer works with iota
Jun 24, 2013
Andrej Mitrovic
Jun 24, 2013
Andrej Mitrovic
Jun 24, 2013
Andrej Mitrovic
Jun 24, 2013
Andrej Mitrovic
Jun 25, 2013
Andrej Mitrovic
June 24, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10468

           Summary: Regression (2.063): Lockstep no longer works with iota
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: regression
          Priority: P2
         Component: Phobos
        AssignedTo: andrej.mitrovich@gmail.com
        ReportedBy: andrej.mitrovich@gmail.com


--- Comment #0 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-06-24 15:02:45 PDT ---
-----
module test;
import std.range;

void main()
{
    foreach (x, y; lockstep(iota(0, 10), iota(0, 10)))
    {
    }
}
-----

$ dmd test.d

C:\DMD\dmd2\windows\bin\..\..\src\phobos\std\range.d(4716): Error: delegate dg
(ref int, ref int) is not callable using argument types (int, int)
test.d(6): Error: opApply() function for Lockstep!(Result, Result) must return
an int
C:\DMD\dmd2\windows\bin\..\..\src\phobos\std\range.d(4717): Error: delegate dg
(uint, ref int, ref int) is not callable using argument types (uint, int, int)

This is introduced as a result of my refactor pull, which added 'ref' to the parameter types by mistake: https://github.com/D-Programming-Language/phobos/pull/1124

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
June 24, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10468



--- Comment #1 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-06-24 15:05:37 PDT ---
(In reply to comment #0)
> This is introduced as a result of my refactor pull, which added 'ref' to the parameter types by mistake: https://github.com/D-Programming-Language/phobos/pull/1124

Actually scratch that, it seems to be more involved. When I simply remove 'ref' then I get errors in other places. I'll investigate more.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
June 24, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10468



--- Comment #2 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-06-24 15:17:43 PDT ---
(In reply to comment #1)
> (In reply to comment #0)
> > This is introduced as a result of my refactor pull, which added 'ref' to the parameter types by mistake: https://github.com/D-Programming-Language/phobos/pull/1124
> 
> Actually scratch that, it seems to be more involved. When I simply remove 'ref' then I get errors in other places. I'll investigate more.

Ah I see what I've missed, the hasLvalueElements check. I'm making a pull shortly.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
June 24, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10468


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull


--- Comment #3 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-06-24 15:18:34 PDT ---
https://github.com/D-Programming-Language/phobos/pull/1370

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
June 25, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10468



--- Comment #4 from github-bugzilla@puremagic.com 2013-06-25 03:50:26 PDT ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/4727fdde0b2df02ebfca9e340cb38c9e3250f27e
Fixes Issue 10468 - Remove ref from parameter type in lockstep, which caused a
regression.

https://github.com/D-Programming-Language/phobos/commit/25ac708f018421e1a90eb8f33fab23b77bc71ed0 Merge pull request #1370 from AndrejMitrovic/Fix10468

(Regression 2.063) - Issue 10468 - Remove ref hardcoded from parameter type in
lockstep

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
June 25, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=10468


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------