http://d.puremagic.com/issues/show_bug.cgi?id=10550



--- Comment #10 from Masahiro Nakagawa <repeatedly@gmail.com> 2013-07-08 09:26:03 PDT ---
(In reply to comment #9)
> ...
> In summary, I think we can proceed as follows:
> 
>    * confirm with experts in the field the typos in the paper
> 
>    * generate new checking sequences with corrected versions of the C code
> 
>    * correct the D code and unittests accordingly
> 
> I am actually inclined to jump ahead with getting the patches to Phobos done, because I'm pretty confident my analysis here is correct :-)

I rechecked the paper and I agree with you (y^=, a < c and 160's >>)
So I think we can fix this paper derived bugs.
Could you send the pull request?
After passed auto tester, I will merge it.

On the other hand, confirm the typos is good for future generations.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10550



--- Comment #11 from Joseph Rushton Wakeling <joseph.wakeling@webdrake.net> 2013-07-08 09:47:04 PDT ---
(In reply to comment #10)
> I rechecked the paper and I agree with you (y^=, a < c and 160's >>)
> So I think we can fix this paper derived bugs.
> Could you send the pull request?
> After passed auto tester, I will merge it.

Yes, I'll get that submitted either later this evening or tomorrow. :-)

> On the other hand, confirm the typos is good for future generations.

Agree.  I also think it could be a good way to begin outreach to the PRNG academic community -- see: http://d.puremagic.com/issues/show_bug.cgi?id=10572

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10550



--- Comment #12 from Joseph Rushton Wakeling <joseph.wakeling@webdrake.net> 2013-07-08 12:49:09 PDT ---
(In reply to comment #11)
> (In reply to comment #10)
> > I rechecked the paper and I agree with you (y^=, a < c and 160's >>)
> > So I think we can fix this paper derived bugs.
> > Could you send the pull request?
> > After passed auto tester, I will merge it.
> 
> Yes, I'll get that submitted either later this evening or tomorrow. :-)

First step -- corrected reference code: https://github.com/WebDrake/xorshift

I first implemented versions that match _exactly_ Marsaglia's sample code, and
that reproduce the checking values from std.random:
https://github.com/WebDrake/xorshift/blob/4305bd5a0ac4d94f59505713a085b34d2e4d482e/xorshift.c

Subsequent commits correct the typos we've observed, and so the current version can be used to generate updated checking values.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10550



--- Comment #13 from Joseph Rushton Wakeling <joseph.wakeling@webdrake.net> 2013-07-08 14:31:53 PDT ---
Pull request submitted: https://github.com/D-Programming-Language/phobos/pull/1403

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10550



--- Comment #14 from github-bugzilla@puremagic.com 2013-07-08 22:48:03 PDT ---
Commit pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/e1504f70b8cfdf4cd1082408fe2452a71e299ab3 Merge pull request #1403 from WebDrake/xorshift

Fix Issue 10550 - Xorshift32 and Xorshift160 do not generate uniformly-distributed random numbers

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10550



--- Comment #15 from Joseph Rushton Wakeling <joseph.wakeling@webdrake.net> 2013-07-09 01:04:56 PDT ---
Masahiro -- thanks so much for your fast attention to this. :-)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10550


Joseph Rushton Wakeling <joseph.wakeling@webdrake.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


--- Comment #16 from Joseph Rushton Wakeling <joseph.wakeling@webdrake.net> 2013-07-09 11:16:30 PDT ---
I think we can now close the bug, but I will try and follow up with some people expert in RNG design to see if we can confirm the fixes really are correct.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------