http://d.puremagic.com/issues/show_bug.cgi?id=8441



--- Comment #9 from jfanatiker@gmx.at 2013-02-27 08:33:19 PST ---
(In reply to comment #8)
> I don't test std.signal2 module, but the two test cases work with my patch.
> 
> https://github.com/D-Programming-Language/dmd/pull/1660

Awesome! This is really great news! Thank you alot! :-) :-) :-) :-D :-) !!!

I tried it and the problem seems to be fixed, but I ran into different issues (forward reference errors and runtime errors). I still have to figure out whether this is related to your changes or not. (The runtime errors are probably because I am still linking to an old phobos version, as I am not able to build the current one, due to oom problems.)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441



--- Comment #10 from jfanatiker@gmx.at 2013-02-28 08:26:34 PST ---
(In reply to comment #8)
> I don't test std.signal2 module, but the two test cases work with my patch.
> 
> https://github.com/D-Programming-Language/dmd/pull/1660

std.signal2 works too! Thank you!

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrej.mitrovich@gmail.com


--- Comment #11 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-07-09 10:51:10 PDT ---
(In reply to comment #10)
> (In reply to comment #8)
> > I don't test std.signal2 module, but the two test cases work with my patch.
> > 
> > https://github.com/D-Programming-Language/dmd/pull/1660
> 
> std.signal2 works too! Thank you!

@jfanatiker@gmx.at: I've tried your std.signals by compiling with 'dmd -c -o- -unittest signals.d' (the unittest switch is important here), specifically I've tried two commits for signals2:

04c951e34623e9365a3874c89f43eb997a7b376c (dav1d told me you said this might
work)
4f7aaba0135bdfebfe54cbd645ca3652b0b0eb7a (git-head)

I've tried them both with the current state of Pull 1660, but compilation fails due to those mixin conflicts. Can you verify this?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441



--- Comment #12 from jfanatiker@gmx.at 2013-07-09 11:57:15 PDT ---
> I've tried them both with the current state of Pull 1660, but compilation fails due to those mixin conflicts. Can you verify this?

HEAD definitely won't work at all. The older commit used to work for me, but pull 1660 changed quite significantly since then. Seeing that there is real use of my implementation I'm shifting it up in my priority list, prepare to see some commits in the next days. I will comment on pull 1660 if I find any issues.

Best regards,
Robert

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441



--- Comment #13 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-07-09 15:29:03 PDT ---
(In reply to comment #12)
> > I've tried them both with the current state of Pull 1660, but compilation fails due to those mixin conflicts. Can you verify this?
> 
> HEAD definitely won't work at all. The older commit used to work for me, but pull 1660 changed quite significantly since then. Seeing that there is real use of my implementation I'm shifting it up in my priority list, prepare to see some commits in the next days. I will comment on pull 1660 if I find any issues.
> 
> Best regards,
> Robert

Btw why are you using mixin templates instead of a struct? I know the current std.signals uses it, but it's broken because people keep running into Issue 5028.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441



--- Comment #14 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-07-09 15:29:34 PDT ---
(In reply to comment #13)
> Issue 5028.

Link: http://d.puremagic.com/issues/show_bug.cgi?id=5028

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441



--- Comment #15 from jfanatiker@gmx.at 2013-07-09 22:43:28 PDT ---
> Btw why are you using mixin templates instead of a struct? I know the current std.signals uses it, but it's broken because people keep running into Issue 5028.

Instead is not quite correct, the mixin is just a wrapper around the FullSignal struct.

Reasoning:  So only containing object can emit signals. (emit is made private)

It is just a convenience wrapper which implements a good default behaviour in just one line of code. (Make emit private) Otherwise you would have to instantiate a FullSignal as private and manually provide methods for accessing the RestrictedSignal for making connections. Not too much work, but a little annoying.

You can of course use the struct directly if you want.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441



--- Comment #16 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-07-10 07:30:35 PDT ---
(In reply to comment #15)
> > Btw why are you using mixin templates instead of a struct? I know the current std.signals uses it, but it's broken because people keep running into Issue 5028.
> 
> Instead is not quite correct, the mixin is just a wrapper around the FullSignal struct.

Ah you mean 'RestrictedSignal', the other one has a private alias. Ok then.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441



--- Comment #17 from jfanatiker@gmx.at 2013-07-12 14:43:48 PDT ---
I just finished a new implementation, replacing the template mixin with a string mixin. You can find it here:

https://github.com/phobos-x/phobosx/blob/master/source/phobosx/signal.d

All unittests pass, you don't need any patched compiler. I still have to add some more checks and do some polishing, I will also put it in the dub registry. But you and David seem to have an urgent need, so feel free to try it out immediately - Be my pre-alpha Testers :-)

Best regards,

Robert

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=8441


jfanatiker@gmx.at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|9347                        |
           Severity|blocker                     |major


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------