Thread overview
[Issue 9310] New: escapeShellCommand unittests are never run
Jan 13, 2013
Andrej Mitrovic
Sep 17, 2013
Andrej Mitrovic
Oct 09, 2013
Andrej Mitrovic
January 13, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9310

           Summary: escapeShellCommand unittests are never run
           Product: D
           Version: D2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Phobos
        AssignedTo: nobody@puremagic.com
        ReportedBy: andrej.mitrovich@gmail.com


--- Comment #0 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-01-12 17:34:28 PST ---
The unitttests are not run at all for this function, because -version=unittest_burnin is never set in Phobos. Note that running the tests would have prevented the newly discovered compiler regression: http://d.puremagic.com/issues/show_bug.cgi?id=9309

Which was found thanks to this report: http://d.puremagic.com/issues/show_bug.cgi?id=9307

As a result `escapeShellCommand` is completely unusable in 2.061 because it always returns an empty string.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
February 25, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9310



--- Comment #1 from github-bugzilla@puremagic.com 2013-02-24 16:53:28 PST ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/128f1e4f3a5422d893990550b8f5dc26e2d5ea13 std.process: Add an additional unit test for escapeShellCommand (issue 9310)

https://github.com/D-Programming-Language/phobos/commit/71079e3901907343c27e5781a6150912782daead Merge pull request #1161 from CyberShadow/std-process-additional-unittest

std.process: Add an additional unit test for escapeShellCommand (issue 9310)

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
September 17, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9310


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull
         AssignedTo|nobody@puremagic.com        |andrej.mitrovich@gmail.com


--- Comment #2 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-09-17 15:44:16 PDT ---
https://github.com/D-Programming-Language/phobos/pull/1583

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
October 09, 2013
http://d.puremagic.com/issues/show_bug.cgi?id=9310


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------