http://d.puremagic.com/issues/show_bug.cgi?id=10866



--- Comment #19 from Dmitry Olshansky <dmitry.olsh@gmail.com> 2013-10-12 01:34:24 PDT ---
(In reply to comment #18)
> (In reply to comment #17)
> > I think our only way out is to isolate the unicode_tables is separate compilation + ~ .di file so that compiler doesn't have to re-tokenize 1.3M file.
> 
> Please do so!

I stand corrected as I just tested it.
This is not a fix, it would be just another huge regression: everything in
std.uni would stop being CTFE-able at all. This cascades to things such as
toLower, isGraphical and such that are being used everywhere.

It would also destroy my effort to free std.regex from reinventing its own unicode stuff internally.

I'm going to investigate what exactly takes that much time

e.g. dmd -c std\internal\unicode_tables.d

Takes around 110 ms for me, quite a lot but not a showstopper. That means both tokenization and compilation was performed and yet even half a second is not seen.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10866



--- Comment #23 from Martin Nowak <code@dawg.eu> 2013-10-13 12:00:11 PDT ---
(In reply to comment #22)
> This gets it down to ~90 ms. https://github.com/D-Programming-Language/phobos/pull/1632

Merged, but the table usage is still flawed.
You put one instance of simpleCaseTable into every template instantiation of
std.uni.sicmp (same for fullCaseTable and fullCasedCmp).
So you have redundancy in the object files and compile overhead when
instantiating sicmp/icmp.

https://github.com/D-Programming-Language/phobos/pull/1636

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10866



--- Comment #24 from Walter Bright <bugzilla@digitalmars.com> 2013-10-13 16:20:23 PDT ---
What happened to making internal_tables.di ?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10866



--- Comment #25 from Dmitry Olshansky <dmitry.olsh@gmail.com> 2013-10-13 22:52:35 PDT ---
(In reply to comment #24)
> What happened to making internal_tables.di ?

Kills CTFE like I said and hence not an option.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10866



--- Comment #26 from github-bugzilla@puremagic.com 2013-10-15 13:54:15 PDT ---
Commit pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/5b5b5bbb68163a42e22cdb55e4f6dcc74a92609b Merge pull request #1636 from dawgfoto/issue10866

make case tables immutable

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10866



--- Comment #27 from github-bugzilla@puremagic.com 2013-10-15 13:57:49 PDT ---
Commit pushed to 2.064 at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/5ee489620f82fbef10b0c9346283c74e28ac2c67 Merge pull request #1636 from dawgfoto/issue10866

make case tables immutable

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10866



--- Comment #28 from Dmitry Olshansky <dmitry.olsh@gmail.com> 2013-10-18 11:00:12 PDT ---
This should be fixed now.
Andrej could you please retest your projects and see if the latest beta has
good timings?

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

http://d.puremagic.com/issues/show_bug.cgi?id=10866


Andrej Mitrovic <andrej.mitrovich@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


--- Comment #29 from Andrej Mitrovic <andrej.mitrovich@gmail.com> 2013-10-18 14:44:44 PDT ---
(In reply to comment #28)
> This should be fixed now.
> Andrej could you please retest your projects and see if the latest beta has
> good timings?

Yeah, it's down to ~600 msecs now.

I'm consistently getting a 200 msec increase from 2.063.2 (~400 msecs) to latest git-head, but I think it's safe to mark this as fixed. The slight increase of the hello world build time is barely noticeable now.

Thanks for the hard work.

-- 
Configure issuemail: http://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------