https://d.puremagic.com/issues/show_bug.cgi?id=11671


monarchdodra@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |monarchdodra@gmail.com


--- Comment #9 from monarchdodra@gmail.com 2013-12-04 00:26:49 PST ---
Can you confirm this is now fixed?

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=11671



--- Comment #10 from Dmitry Olshansky <dmitry.olsh@gmail.com> 2013-12-04 10:23:52 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > Works for me, I run
> > 
> > dmd dget.d
> > 
> > with whatever version of DMD 2.065 alpha I had.
> 
> It failed for me on that step:
> dmd -c -ofgenerated/osx/64/dget.o dget.d
> (on osx)
> and it worked with my pull.
> (note, I'm building from git head)

You are right, it's a recent regression caused by my refactoring.
Sadly we don't have (yet) a way to test accessibility of symbols, I hope that
will come with splitting up modules.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=11671


Jakob Ovrum <jakobovrum@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakobovrum@gmail.com


--- Comment #11 from Jakob Ovrum <jakobovrum@gmail.com> 2013-12-04 10:26:46 PST ---
(In reply to comment #10)
> You are right, it's a recent regression caused by my refactoring.
> Sadly we don't have (yet) a way to test accessibility of symbols, I hope that
> will come with splitting up modules.

Technically we can test it with `__traits(getProtection, symbol)`. This is probably the kind of thing that would become more practical with a more advanced testing library than the barebones we get by default.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=11671



--- Comment #12 from monarchdodra@gmail.com 2013-12-04 13:09:47 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > You are right, it's a recent regression caused by my refactoring.
> > Sadly we don't have (yet) a way to test accessibility of symbols, I hope that
> > will come with splitting up modules.
> 
> Technically we can test it with `__traits(getProtection, symbol)`. This is probably the kind of thing that would become more practical with a more advanced testing library than the barebones we get by default.

Another (simpler) solution would be to include "programs" with phobos that are
part of the testing suite. Not only would it cover things a bit more
"real-world"-ish then the "unitary" "unittests", but it would also cover the
public/private issues (you don't cover with unittests), as well as make sure it
still works outside of a "version(unittest)" case (we've had a couple of these
too).

Currently, the closest we have is "dmd"'s testing suite: I've seen more than a couple of additions to phobos that passed phobo's test's with flying colors, but *broke* dmd's test suite: Specifically because dmd's test suite is an actual program written in D.

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=11671



--- Comment #13 from github-bugzilla@puremagic.com 2013-12-09 04:04:56 PST ---
Commit pushed to 2.065 at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/d1800fea048f80071573ddc197f8922cf919a662 Merge pull request #1745 from 9rnsr/fix11671

Issue 11671 - ctRegex broken

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=11671


Kenji Hara <k.hara.pg@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------

https://d.puremagic.com/issues/show_bug.cgi?id=11671



--- Comment #14 from github-bugzilla@puremagic.com 2013-12-19 06:49:43 PST ---
Commits pushed to 2.065 at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/29099f989477a6aa69e2ee833f322bf9e8dbd680 fix Issue 11671 - ctRegex broken

https://github.com/D-Programming-Language/phobos/commit/ea8ad591213384ef4918c51588c550f1ef2d36a6 Merge pull request #1745 from 9rnsr/fix11671

-- 
Configure issuemail: https://d.puremagic.com/issues/userprefs.cgi?tab=email
------- You are receiving this mail because: -------