To all who are generating pull requests:

I get emails for every pull request message that is posted, as do anyone who is subscribed to the github project.

A recent message in my email:



Re: [phobos] Fix issue 12419 (#2038)

@monarchdodra Good point, done.

-
Reply to this email directly or view it on GitHub.




The "view it on Github" is a link to the message. So I can see what this is about. But it would be nice if the pull request title was more descriptive. I don't know what issue 12419 is.

Please note, I am not complaining about the volume of pull request chatter, this is great! But the title of the pull request should describe what it logically is without having to click through to a bug report or read everything about the pull request.

If you want to say "fix issue XXX", please repeat the bug title at least.

-Steve

On 3/24/14, Steven Schveighoffer <schveiguy@yahoo.com> wrote:
> To all who are generating pull requests.

I keep saying the same thing to pull makers. When I'm not too busy I also rename their pull request to add the title description.

Another thing I keep mentioning is to add a link to the bugzilla issue in the pull request.

"Steven Schveighoffer"  wrote in message news:op.xc8mg5laeav7ka@stevens-macbook-pro.local...

> The "view it on Github" is a link to the message. So I can see what this is about. But it would be nice if the pull request title was more descriptive. I don't know what issue 12419 is.

It does say this in the wiki: http://wiki.dlang.org/Pull_Requests#Create_a_pull_request

Don't forget you can edit the titles of other people's pull requests! 

On 3/24/2014 12:47 PM, Andrej Mitrovic wrote:
> On 3/24/14, Steven Schveighoffer <schveiguy@yahoo.com> wrote:
>> To all who are generating pull requests.
>
> I keep saying the same thing to pull makers. When I'm not too busy I
> also rename their pull request to add the title description.
>
> Another thing I keep mentioning is to add a link to the bugzilla issue
> in the pull request.
>

Yes, indeed. I think it's just polite to include a link to the bugzilla issue as well as a link in the bugzilla issue back to the PR.

On Monday, 24 March 2014 at 17:49:43 UTC, Steven Schveighoffer wrote:
> To all who are generating pull requests:
>
> I get emails for every pull request message that is posted, as do anyone who is subscribed to the github project.

Though I agree with everything you said, it is possible to "watch" a repository without receiving email notifications, for those who are fine with just the web interface's notification system.

On Monday, 24 March 2014 at 17:49:43 UTC, Steven Schveighoffer wrote:
> If you want to say "fix issue XXX", please repeat the bug title at least.
>
> -Steve

Yeah, that does get on my nerves sometimes too. But I do nothing about it, so I'm not part of the solution. I guess I should now.

Also, when fixing an issue, *please* provide a link to said issue. Searching for "XXX" in the bug repo myself is un-necessary overhead.

On Tuesday, 25 March 2014 at 06:45:30 UTC, monarch_dodra wrote:
> On Monday, 24 March 2014 at 17:49:43 UTC, Steven Schveighoffer wrote:
>> If you want to say "fix issue XXX", please repeat the bug title at least.
>>
>> -Steve
>
> Yeah, that does get on my nerves sometimes too. But I do nothing about it, so I'm not part of the solution. I guess I should now.
>
> Also, when fixing an issue, *please* provide a link to said issue. Searching for "XXX" in the bug repo myself is un-necessary overhead.

Tip: go to Bugzilla, right-click the "Search" field at the top, and select "Create search". Assign a keyboard (e.g. "db" for "D Bugs"), and then you can go to any issue by typing "db NNNNN" in the address bar (or search Bugzilla by entering search terms instead of NNNNN).

On 3/24/2014 11:58 PM, Vladimir Panteleev wrote:
> Tip: go to Bugzilla, right-click the "Search" field at the top, and select
> "Create search". Assign a keyboard (e.g. "db" for "D Bugs"), and then you can go
> to any issue by typing "db NNNNN" in the address bar (or search Bugzilla by
> entering search terms instead of NNNNN).

I do it an even easier way. I go to a bugzilla issue from my browser history, then edit the address with a new NNNNN :-)

On Monday, 24 March 2014 at 17:49:43 UTC, Steven Schveighoffer wrote:
> To all who are generating pull requests:
>
> I get emails for every pull request message that is posted, as do anyone who is subscribed to the github project.
>
> A recent message in my email:
>
>
>
> Re: [phobos] Fix issue 12419 (#2038)
>
> @monarchdodra Good point, done.
>
> -
> Reply to this email directly or view it on GitHub.
>
>
>
>
> The "view it on Github" is a link to the message. So I can see what this is about. But it would be nice if the pull request title was more descriptive. I don't know what issue 12419 is.
>
> Please note, I am not complaining about the volume of pull request chatter, this is great! But the title of the pull request should describe what it logically is without having to click through to a bug report or read everything about the pull request.
>
> If you want to say "fix issue XXX", please repeat the bug title at least.
>
> -Steve

I know exactly what you are talking about. I had this same issue with git at one of my previous jobs. We used to have commit messages that were tied to tickets, and we'd have messages like, "Fix so and so." So I started using the convention "#1234 - Fix so and so." So my coworkers noticed this, thought referencing the bug was a good idea and switched... only to writing the bug number in the commit message and nothing else. So 'git log' read kind of like this.

Bob - "#347"
Joe - "#346"
Me - "#345 - Fix a rendering bug with this thing on this machine."
Bob - "#228"

It was really frustrating.

On Tuesday, 25 March 2014 at 06:58:53 UTC, Vladimir Panteleev wrote:
> Tip: go to Bugzilla, right-click the "Search" field at the top, and select "Create search". Assign a keyboard (e.g. "db" for "D Bugs"), and then you can go to any issue by typing "db NNNNN" in the address bar (or search Bugzilla by entering search terms instead of NNNNN).

On Tuesday, 25 March 2014 at 07:03:24 UTC, Walter Bright wrote:
> I do it an even easier way. I go to a bugzilla issue from my browser history, then edit the address with a new NNNNN :-)

Good tips (Walter, I mostly use your strategy), but still something I shouldn't have to put up with.

I'd simply call it common decency to link whatever you are talking to...