trash-d: Replacement for rm that uses the trash bin (page 2)

On Wednesday, 25 August 2021 at 13:30:58 UTC, rushsteve1 wrote:

On Wednesday, 25 August 2021 at 06:23:37 UTC, Kagamin wrote:

You marked all functions inline?

If I did then it wasn't on purpose, I was only trying to mark the handful of helper functions as inline. If you know a solution to this, that would be greatly appreciated!

When you use an attribute with a colon after it, like you do on line 232 of trash.d:

pragma(inline):

Then it applies not just to the next declaration, but to all subsequent declarations in the same scope (which in this case is the entire rest of the module).

(Source: first paragraph in the "Attributes" section of the spec.)

To avoid this, just remove the colon.

To be honest, you could probably remove pragma(inline) from the program altogether and not notice a difference. A program like this is almost certainly going to be bottlenecked on IO long before function-call overhead makes a noticeable difference to performance.

August 25, 2021

Re: trash-d: Replacement for rm that uses the trash bin

Posted by Vladimir Panteleev
in reply to rushsteve1

Permalink

Vladimir Panteleev

Posted in reply to rushsteve1

Permalink

On Wednesday, 25 August 2021 at 13:30:36 UTC, rushsteve1 wrote:

trash-d tries to mimic rm's semantics as much as possible. It also unifies all the different trash-* commands that trash-cli provides into a single one with flags. One of my goals with trash-d was to make a simpler and smaller alternative to trash-cli.

That makes sense, thanks!

The only advantage that trash-cli has that I know of (aside from maturity at this point) is that it handles .Trash/ directories on separate drives/partitions while trash-d always moves to the one in the user's home. Both approaches are spec-compliant, so I opted for the simpler one.

I suggest investigating that as a future improvement. Not only is moving files within the same volume much faster (potentially an O(1) operation as opposed to having to read then write every byte of data), but it can also result in space savings (in the case of filesystem snapshots).

Forums