https://issues.dlang.org/show_bug.cgi?id=23959

Teodor Dutu <teodor.dutu@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |teodor.dutu@gmail.com
           Assignee|nobody@puremagic.com        |teodor.dutu@gmail.com

--

https://issues.dlang.org/show_bug.cgi?id=23959

--- Comment #1 from Dlang Bot <dlang-bot@dlang.rocks> ---
@teodutu created dlang/dmd pull request #15295 "Move lowerings to `_d_array{setassign,assign_{l,r}}` to a `LoweredAssignExp` AST node" mentioning this issue:

- Move lowerings to `_d_array{setassign,assign_{l,r}}` to a `LoweredAssignExp` AST node

  This PR does the following:
  - uses a `LoweredAssignExp` node for assignmets that lower to
  `_d_arrayassign_{l,r}`
  - removes the code in `dinterpret.d` that recreates the original
  `AssigExp`
  - simplifies `isArrayConstructionOrAssign()` to just
    `isArrayConstruction()` since assignments are now handled by a separate
  AST node
  - fixes issue 23959

  Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>

https://github.com/dlang/dmd/pull/15295

--

https://issues.dlang.org/show_bug.cgi?id=23959

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
@teodutu created dlang/dmd pull request #15315 "Fix Issue 23959 - Propagate deprecation to `_d_arrayappendcTXImpl` if the calling scope is deprecated" fixing this issue:

- Fix Issue 23959 - Propagate deprecation to `_d_arrayappendcTXImpl` if the calling scope is deprecated

  This is needed if the lowered expression (`arr ~= elem`) is made within
  a deprecated context to avoid spurious deprecation messages about the
  hook being emitted.

  Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>

https://github.com/dlang/dmd/pull/15315

--

https://issues.dlang.org/show_bug.cgi?id=23959

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #15295 "Move lowerings to `_d_array{setassign,assign_{l,r}}` to a `LoweredAssignExp` AST node" was merged into stable:

- 196d3a4c0649094353b56fb3af81cccc014ee8c8 by Teodor Dutu:
  Fix Issue 23959 - Move lowerings to `_d_array{setassign,assign_{l,r}}` to a
`LoweredAssignExp` AST node

  The compiler now uses a `LoweredAssignExp` node for assignmets that
  lower to `_d_arrayassign_{l,r}`

  Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>

https://github.com/dlang/dmd/pull/15295

--