On Wednesday, November 27, 2013 11:39:48 Joseph Rushton Wakeling wrote:
> Hello all,
> 
> I'm currently messing around in the internals of std.complex (cf. discussion
> on main mailing list:-).  In Complex.toString there is a deprecation
> message asking the user to "use std.format.format()".
> 
> However, so far as I can tell both via docs and browsing std/format.d there
> _is_ no std.format.format() -- there's only std.string.format().
> 
> So, what gives? :-)

I think that it's pretty clear that the deprecation message is wrong.

- Jonathan M Davis

On Wed, Nov 27, 2013 at 03:30:51AM -0800, Jonathan M Davis wrote:
> On Wednesday, November 27, 2013 11:39:48 Joseph Rushton Wakeling wrote:
> > Hello all,
> > 
> > I'm currently messing around in the internals of std.complex (cf.
> > discussion on main mailing list:-).  In Complex.toString there is a
> > deprecation message asking the user to "use std.format.format()".
> > 
> > However, so far as I can tell both via docs and browsing
> > std/format.d there _is_ no std.format.format() -- there's only
> > std.string.format().
> > 
> > So, what gives? :-)
> 
> I think that it's pretty clear that the deprecation message is wrong.
[...]

And that would be my fault. I believe it was one of my pulls that contained that wrong doc. Anybody care to submit a pull to fix that? :-)


T

-- 
My program has no bugs! Only undocumented features...

On 27/11/13 16:14, H. S. Teoh wrote:
> And that would be my fault. I believe it was one of my pulls that
> contained that wrong doc. Anybody care to submit a pull to fix that? :-)

I'll take care of it.  I'm working on an Imaginary struct to complement std.complex.Complex so it's trivial to make that fix.

I was fairly sure the error was in the deprecation message, but wanted to be sure it didn't reflect some kind of long-term plans.

On Wednesday, 27 November 2013 at 15:54:48 UTC, Joseph Rushton Wakeling wrote:
> On 27/11/13 16:14, H. S. Teoh wrote:
>> And that would be my fault. I believe it was one of my pulls that
>> contained that wrong doc. Anybody care to submit a pull to fix that? :-)
>
> I'll take care of it.  I'm working on an Imaginary struct to complement std.complex.Complex so it's trivial to make that fix.
>
> I was fairly sure the error was in the deprecation message, but wanted to be sure it didn't reflect some kind of long-term plans.

If what you are doing is "non-trivial" though, it's better to submit two different pulls for it.

On 27/11/13 17:38, monarch_dodra wrote:
> If what you are doing is "non-trivial" though, it's better to submit two
> different pulls for it.

Understood.  Pull request for the ddoc/deprecation message fix:
https://github.com/D-Programming-Language/phobos/pull/1730

On 27/11/13 18:55, Joseph Rushton Wakeling wrote:
> Understood.  Pull request for the ddoc/deprecation message fix:
> https://github.com/D-Programming-Language/phobos/pull/1730

Thanks for the quick merge.  std.complex.Imaginary to follow :-)

On Wednesday, November 27, 2013 21:12:07 Joseph Rushton Wakeling wrote:
> On 27/11/13 18:55, Joseph Rushton Wakeling wrote:
> > Understood. Pull request for the ddoc/deprecation message fix: https://github.com/D-Programming-Language/phobos/pull/1730
> 
> Thanks for the quick merge. std.complex.Imaginary to follow :-)

I don't know... Is it actually possible merge imaginary code? ;)

- Jonathan M Davis

On 27/11/13 23:07, Jonathan M Davis wrote:
> I don't know... Is it actually possible merge imaginary code? ;)

Yes, but the lines run up and down the screen ;-)