https://issues.dlang.org/show_bug.cgi?id=16209

Martin Nowak <code@dawg.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |code@dawg.eu

--- Comment #1 from Martin Nowak <code@dawg.eu> ---
This PR added support for random access ranges. https://github.com/dlang/phobos/pull/4322

--

https://issues.dlang.org/show_bug.cgi?id=16209

Lucia Cojocaru <lucia.mcojocaru@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucia.mcojocaru@gmail.com

--- Comment #2 from Lucia Cojocaru <lucia.mcojocaru@gmail.com> ---
Should this issue be marked as resolved?

--

https://issues.dlang.org/show_bug.cgi?id=16209

--- Comment #3 from Jack Stouffer <jack@jackstouffer.com> ---
(In reply to Lucia Cojocaru from comment #2)
> Should this issue be marked as resolved?

No because isNumeric doesn't yet work with forward ranges.

--

https://issues.dlang.org/show_bug.cgi?id=16209

Andrei Alexandrescu <andrei@erdani.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrei@erdani.com

--- Comment #4 from Andrei Alexandrescu <andrei@erdani.com> ---
I think we should just undocument `isNumeric` and cease enhancing it. It's a terrible function. A simple way to figure out whether something is numeric is simply parse it as a number - the work done is similar and you get the number too.

--

https://issues.dlang.org/show_bug.cgi?id=16209

--- Comment #5 from Jack Stouffer <jack@jackstouffer.com> ---
(In reply to Andrei Alexandrescu from comment #4)
> I think we should just undocument `isNumeric` and cease enhancing it. It's a terrible function. A simple way to figure out whether something is numeric is simply parse it as a number - the work done is similar and you get the number too.

1. someone would first need to make sure that every input on isNumeric works
with parse
2. and if so we could just make isNumeric forward to parse

That way you don't have to go through the deprecation cycle.

I doubt that parse can handle all of the esoteric inputs that isNumeric can handle right now.

--

https://issues.dlang.org/show_bug.cgi?id=16209

--- Comment #6 from Andrei Alexandrescu <andrei@erdani.com> ---
(In reply to Jack Stouffer from comment #5)
> I doubt that parse can handle all of the esoteric inputs that isNumeric can handle right now.

That's part of the problem. There's very little use of a function that tells you something is numeric, that is not complemented by a function that tells you what the actual number is.

This function is inspired from scripting languages that need it for logic such as "if it looks like a number, consider it a number". Has no place in D.

--

https://issues.dlang.org/show_bug.cgi?id=16209

greenify <greeenify@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |trivial
                 CC|                            |greeenify@gmail.com

--

https://issues.dlang.org/show_bug.cgi?id=16209

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P4

--

https://issues.dlang.org/show_bug.cgi?id=16209

--- Comment #7 from dlangBugzillaToGithub <robert.schadek@posteo.de> ---
THIS ISSUE HAS BEEN MOVED TO GITHUB

https://github.com/dlang/phobos/issues/9688

DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB

--