https://issues.dlang.org/show_bug.cgi?id=18675

Jack Stouffer <jack@jackstouffer.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17206


Referenced Issues:

https://issues.dlang.org/show_bug.cgi?id=17206
[Issue 17206] Checks that opEquals and toHash are both defined or neither are
defined
--

https://issues.dlang.org/show_bug.cgi?id=18675

vladvitan@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vladvitan@gmail.com
              Alias|                            |vlasebian

--

https://issues.dlang.org/show_bug.cgi?id=18675

--- Comment #1 from vladvitan@gmail.com ---
I want to work on this. Could you please give me a starting point for this? Should I use the toHash() functionality from druntime?

--

https://issues.dlang.org/show_bug.cgi?id=18675

vladvitan@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@puremagic.com        |vladvitan@gmail.com

--

https://issues.dlang.org/show_bug.cgi?id=18675

--- Comment #2 from Jack Stouffer <jack@jackstouffer.com> ---
(In reply to vladvitan from comment #1)
> I want to work on this. Could you please give me a starting point for this? Should I use the toHash() functionality from druntime?

Yes, or you can use typeid(var).getHash(&var).

You'll have to put this inside of a trusted lambda in order for it to be @safe.

The main thing you need to make sure is that it follows the logic of opEquals, i.e. two things have the same hash according to opEquals' logic.

--

https://issues.dlang.org/show_bug.cgi?id=18675

Seb <greensunny12@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |greensunny12@gmail.com

--- Comment #3 from Seb <greensunny12@gmail.com> ---
Just referencing the PR https://github.com/dlang/phobos/pull/6467 for people who look t this in the future while the PR is still open.

--

https://issues.dlang.org/show_bug.cgi?id=18675

--- Comment #4 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/f21833ff154cfd1a405115f2bf79dca55151721c Fix Issue 18675 - Missing toHash in std/experimental/checkedint.d

https://github.com/dlang/phobos/commit/a681e986a3295aa59211ed8194e4e4af3a1a4b34 Merge pull request #6467 from vlasebian/checked_toHash

Fix Issue 18675 - Missing toHash in std/experimental/checkedint.d merged-on-behalf-of: Nathan Sashihara <n8sh@users.noreply.github.com>

--

https://issues.dlang.org/show_bug.cgi?id=18675

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--