On Fri, Aug 5, 2011 at 9:10 AM, torhu <no@spam.invalid> wrote:

> On 05.08.2011 14:00, Denis Shelomovskij wrote:
>
>> Actually, that is completely false. Git and HG were released within
>>> a month of eachother, have very similar feature sets, and didn't really influence eachother during development. Github is exclusively for Git, and Bitbucket is exclusively for Mercurial because you can't really mix them at all. It's a matter of taste, not a matter of "fixed issues." They're different programs built at the same time to accomplish the same goals.
>>>
>>
>> I don't use SCM often. IMHO, SCM should just work. HG is simplier
>> than Git (not only IMHO). So, it's a Git issue (for me) not to be as
>> simple as HG.
>
>
> Another thing in Mercurial's favor is that it's not made and maintained by people who couldn't care less about Windows.
>

In my experience, that hasn't made any difference. The Mercurial folks recommend TortoiseHG, and there's also TortoiseGit with the same feature set. I use Eclipse with DDT for most of my development, and there's MercurialEclipse and EGit.

On Fri, Aug 5, 2011 at 1:36 AM, Andrew Wiley <wiley.andrew.j@gmail.com>wrote:

>
>
> On Fri, Aug 5, 2011 at 2:23 AM, Denis Shelomovskij < verylonglogin.reg@gmail.com> wrote:
>
>> 05.08.2011 9:38, Jacob Carlborg пишет:
>>
>>  On 2011-08-04 16:16, Jesse Phillips wrote:
>>>
>>>> On Thu, 04 Aug 2011 08:27:26 +0200, Jacob Carlborg wrote:
>>>>
>>>>  I'm so sorry. I haven't prioritized DWT and I've forgotten pull
>>>>> requests
>>>>> and patches in tickets. I will look into this. Maybe I can move the
>>>>> repository to bitbucket or github, this will make it easier creating
>>>>> and
>>>>> merging pull requests.
>>>>>
>>>>
>>>> I'm bias toward Git, I'm really liking submodules.
>>>>
>>>
>>> I like both git and github more than mercurial and bitbucket. Many seem to switch to github for their D development; DMD, Phobos Druntime; all of them are now on github. But on the other hand the DWT repository is already a mercurial repository and there are several forks on bitbucket.
>>>
>>
>>
>> Why? IMHO hg is better than git (newer program that fixed issues of older git and svn). Maybe github is convenient but it isn't because of git. It's a big shortcoming of github not to support hg.
>>
>
> Actually, that is completely false. Git and HG were released within a month of eachother, have very similar feature sets, and didn't really influence eachother during development. Github is exclusively for Git, and Bitbucket is exclusively for Mercurial because you can't really mix them at all. It's a matter of taste, not a matter of "fixed issues." They're different programs built at the same time to accomplish the same goals.
>

Actually, it looks like you can use Mercurial with Github:
https://github.com/blog/439-hg-git-mercurial-plugin
Not sure if there's an equivalent go go from a Mercurial server to a Git
client.

On Fri, 05 Aug 2011 10:36:02 -0700, Andrew Wiley wrote:

> Actually, it looks like you can use Mercurial with Github: https://github.com/blog/439-hg-git-mercurial-plugin Not sure if there's an equivalent go go from a Mercurial server to a Git client.

You use the same tool but it isn't as easy. Interestingly it is developed by the github staff.

While I would love it to be on Github, I think it would be best to place it where people are already putting their forks. Though maybe it isn't possible to take advantage of the fork/pull request feature as they aren't "official" forks...

On 2011-08-05 19:12, Andrew Wiley wrote:
> On Fri, Aug 5, 2011 at 9:10 AM, torhu <no@spam.invalid> wrote:
>
>     On 05.08.2011 14:00, Denis Shelomovskij wrote:
>
>             Actually, that is completely false. Git and HG were released
>             within
>             a month of eachother, have very similar feature sets, and didn't
>             really influence eachother during development. Github is
>             exclusively for Git, and Bitbucket is exclusively for Mercurial
>             because you can't really mix them at all. It's a matter of
>             taste,
>             not a matter of "fixed issues." They're different programs
>             built at
>             the same time to accomplish the same goals.
>
>
>         I don't use SCM often. IMHO, SCM should just work. HG is simplier
>         than Git (not only IMHO). So, it's a Git issue (for me) not to be as
>         simple as HG.
>
>
>     Another thing in Mercurial's favor is that it's not made and maintained
>     by people who couldn't care less about Windows.
>
>
> In my experience, that hasn't made any difference. The Mercurial folks
> recommend TortoiseHG, and there's also TortoiseGit with the same feature
> set. I use Eclipse with DDT for most of my development, and there's
> MercurialEclipse and EGit.
>

If I recall correctly TortoiseGit didn't work that well when I used it.

-- 
/Jacob Carlborg

On 2011-08-03 22:02, Denis Shelomovskij wrote:
> About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
> time to pull changes to the main repo. Changes are in my (denis_sh)
> commits descriptions:
> https://bitbucket.org/denis_sh/patching-dwt2
>
> Short changes description:
> 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
> worse): lots of segfaults when printing and text editing and other bugs.
> 2. It looks working stable on Windows except Text widget sill doesn't
> support UTF-8 (yes, StyledText and it's friend now support it).
> 3. It now have compilable and right snippets.

I've pulled your changes now. Thanks so much for your help. I can see now that a almost all snippets work. Only two crash on launch. I've not verified that all the others are working 100% correctly but it's looking really good. You've done a great job. And again, I'm so sorry it took me so long before I pulled the changes.

-- 
/Jacob Carlborg

On 10.08.2011 21:32, Jacob Carlborg wrote:
> On 2011-08-03 22:02, Denis Shelomovskij wrote:
>>  About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
>>  time to pull changes to the main repo. Changes are in my (denis_sh)
>>  commits descriptions:
>>  https://bitbucket.org/denis_sh/patching-dwt2
>>
>>  Short changes description:
>>  1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
>>  worse): lots of segfaults when printing and text editing and other bugs.
>>  2. It looks working stable on Windows except Text widget sill doesn't
>>  support UTF-8 (yes, StyledText and it's friend now support it).
>>  3. It now have compilable and right snippets.
>
> I've pulled your changes now. Thanks so much for your help. I can see
> now that a almost all snippets work. Only two crash on launch. I've not
> verified that all the others are working 100% correctly but it's looking
> really good. You've done a great job. And again, I'm so sorry it took me
> so long before I pulled the changes.
>

Nice to see work being done on DWT!  I did notice a slight problem with changeset 121, though.  The array in isDigit needs to be declared static, or it will be copied onto the heap on each call of the function. And the rest of the function could be just this line, simpler and more efficent:

return c >= '0' && c <= '9' || assumeSorted(unicodeNd).contains(c);


Took me a while to find assumeSorted, but it is in std.range.

On 2011-08-11 14:31, torhu wrote:
> On 10.08.2011 21:32, Jacob Carlborg wrote:
>> On 2011-08-03 22:02, Denis Shelomovskij wrote:
>>> About month ago I fixed some DWT2 bugs, but DWT maintainers just have no
>>> time to pull changes to the main repo. Changes are in my (denis_sh)
>>> commits descriptions:
>>> https://bitbucket.org/denis_sh/patching-dwt2
>>>
>>> Short changes description:
>>> 1. DWT2 now works on Linux32 with Phobos/D2 as bad as with Tango/D1 (not
>>> worse): lots of segfaults when printing and text editing and other bugs.
>>> 2. It looks working stable on Windows except Text widget sill doesn't
>>> support UTF-8 (yes, StyledText and it's friend now support it).
>>> 3. It now have compilable and right snippets.
>>
>> I've pulled your changes now. Thanks so much for your help. I can see
>> now that a almost all snippets work. Only two crash on launch. I've not
>> verified that all the others are working 100% correctly but it's looking
>> really good. You've done a great job. And again, I'm so sorry it took me
>> so long before I pulled the changes.
>>
>
> Nice to see work being done on DWT! I did notice a slight problem with
> changeset 121, though. The array in isDigit needs to be declared static,
> or it will be copied onto the heap on each call of the function. And the
> rest of the function could be just this line, simpler and more efficent:
>
> return c >= '0' && c <= '9' || assumeSorted(unicodeNd).contains(c);
>
>
> Took me a while to find assumeSorted, but it is in std.range.

Yeah, that really needs to be static, I'll fix it.

-- 
/Jacob Carlborg

Hey, so why are all those snippets named by numbers? There's a bunch of cool snippets here: http://www.eclipse.org/swt/snippets/

but I can't tell whether they're already in the snippets folder in DWT since they're just named with numbers. I've ported a few to D, the porting process seems to be really simple (in fact it wouldn't be a bad idea to have a script to do the conversion automatically, when it can).

I've also tried to port a Browser snippet, but Browser seems to be a module that's only in the linux packages in dwt.

On 2011-09-05 18:28, Andrej Mitrovic wrote:
> Hey, so why are all those snippets named by numbers? There's a bunch
> of cool snippets here: http://www.eclipse.org/swt/snippets/

Because the java files are named like that: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets

> but I can't tell whether they're already in the snippets folder in DWT
> since they're just named with numbers. I've ported a few to D, the
> porting process seems to be really simple (in fact it wouldn't be a
> bad idea to have a script to do the conversion automatically, when it
> can).

I don't know, maybe. There will always be things that the script can't automatically translate. But you are free to create a script and if it's good enough it can be added to the dwt repository.

> I've also tried to port a Browser snippet, but Browser seems to be a
> module that's only in the linux packages in dwt.

Yes, all browser related code have only been ported for linux. I have no idea if it still works or not. If I recall correctly it didn't work very well when I tried it last time.

-- 
/Jacob Carlborg

Is there a latest update which can get compiled under dmd2.055 under Windows?Thanks.