Thread overview
[Issue 18332] rt.util.random.Rand48 remove unnecessary assert
Jan 30, 2018
Nathan S.
Jan 30, 2018
Nathan S.
Jan 30, 2018
Nathan S.
Jul 02, 2018
Nathan S.
January 30, 2018
https://issues.dlang.org/show_bug.cgi?id=18332

Nathan S. <n8sh.secondary@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|rt.util.random.Rand48       |rt.util.random.Rand48
                   |remove unnecessary assert   |remove unnecessary assert
                   |and mask                    |

--
January 30, 2018
https://issues.dlang.org/show_bug.cgi?id=18332

--- Comment #1 from Nathan S. <n8sh.secondary@hotmail.com> ---
Strike the comments about popFront(): the mask is necessary.

>popFront() advances rng_state through addition and multiplication so the high 16 bits of the current rng_state never affect the low 48 bits of the next rng_state

The "and addition" is why this statement is false.

--
January 30, 2018
https://issues.dlang.org/show_bug.cgi?id=18332

--- Comment #2 from Nathan S. <n8sh.secondary@hotmail.com> ---
Fix in https://github.com/dlang/druntime/pull/2069

--
March 12, 2018
https://issues.dlang.org/show_bug.cgi?id=18332

--- Comment #3 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/druntime

https://github.com/dlang/druntime/commit/3d02a6e72533ee9399a7f2d40caa7c463f2f4020 Issue 18332 - rt.util.random.Rand48 remove unnecessary assert

https://github.com/dlang/druntime/commit/01643aadf0c28be03ca64e6614fb592356a3d40e Merge pull request #2069 from n8sh/rand48

Issue 18332 - rt.util.random.Rand48 remove unnecessary assert

--
July 02, 2018
https://issues.dlang.org/show_bug.cgi?id=18332

Nathan S. <n8sh.secondary@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Nathan S. <n8sh.secondary@hotmail.com> ---
For some reason this didn't auto-close.

--