Thread overview
[Issue 13163] std.conv.parse misses overflow when it doesn't result in a smaller value
[Issue 13163] std.conv.parse misses overflow when it results in the same value
Jul 19, 2014
Nils
Jul 20, 2014
Nils
July 19, 2014
https://issues.dlang.org/show_bug.cgi?id=13163

Nils <nilsbossung@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #1 from Nils <nilsbossung@googlemail.com> ---
https://github.com/D-Programming-Language/phobos/pull/2355

--
July 20, 2014
https://issues.dlang.org/show_bug.cgi?id=13163

Nils <nilsbossung@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|std.conv.parse misses       |std.conv.parse misses
                   |overflow when it results in |overflow when it doesn't
                   |the same value              |result in a smaller value

--- Comment #2 from Nils <nilsbossung@googlemail.com> ---
Another test case by monarchdodra showing that the overflowed value can be greater than the original (duh):

import std.conv;
import std.exception;
void main()
{
    auto s = "123";
    assertThrown!ConvOverflowException(s.parse!ubyte(16)); /* fails */
}

--
July 30, 2014
https://issues.dlang.org/show_bug.cgi?id=13163

--- Comment #3 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/D-Programming-Language/phobos

https://github.com/D-Programming-Language/phobos/commit/efe0d1722b0d873afc9b177edfb052c0fda4181e
fix issue 13163 - std.conv.parse misses overflow when it doesn't result in a
smaller value

https://github.com/D-Programming-Language/phobos/commit/087b2f773274aa31da78ccd77880855c77f4353f Merge pull request #2355 from NilsBossung/13163

fix issue 13163 - std.conv.parse misses overflow when it doesn't result in a smaller value

--
July 30, 2014
https://issues.dlang.org/show_bug.cgi?id=13163

github-bugzilla@puremagic.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--