Thread overview
[Issue 23514] Incorrect compilation when adding a 64-bit constant to a link-time address
Nov 27, 2022
Dlang Bot
Dec 17, 2022
Iain Buclaw
Feb 21, 2023
Dlang Bot
Feb 22, 2023
Dlang Bot
November 27, 2022
https://issues.dlang.org/show_bug.cgi?id=23514

--- Comment #1 from zyedidia@stanford.edu ---
PR opened at: https://github.com/dlang/dmd/pull/14657.

--
November 27, 2022
https://issues.dlang.org/show_bug.cgi?id=23514

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #2 from Dlang Bot <dlang-bot@dlang.rocks> ---
@zyedidia updated dlang/dmd pull request #14657 "Fix issue 23514 - Incorrect compilation when adding a 64-bit constant to a link-time address" fixing this issue:

- Fix issue 23514 - Incorrect compilation when adding a 64-bit constant to a link-time address

  The current cast to int causes a loss of precision, which can result in
  incorrect compilation.

https://github.com/dlang/dmd/pull/14657

--
December 17, 2022
https://issues.dlang.org/show_bug.cgi?id=23514

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P3

--
February 21, 2023
https://issues.dlang.org/show_bug.cgi?id=23514

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #14657 "Fix issue 23514 - Incorrect compilation when adding a 64-bit constant to a link-time address" was merged into stable:

- 9d988bb7c27411232cb3655f674b7e0dc60ffa54 by Zachary Yedidia:
  Fix issue 23514 - Incorrect compilation when adding a 64-bit constant to a
link-time address

  The current cast to int causes a loss of precision, which can result in
  incorrect compilation.

https://github.com/dlang/dmd/pull/14657

--
February 22, 2023
https://issues.dlang.org/show_bug.cgi?id=23514

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #14904 "merge stable" was merged into master:

- cd946d37c46aa2d860ee495ef22ead00cac2e783 by Zachary Yedidia:
  Fix issue 23514 - Incorrect compilation when adding a 64-bit constant to a
link-time address (#14657)

  * Fix issue 23514 - Incorrect compilation when adding a 64-bit constant to a
link-time address

  The current cast to int causes a loss of precision, which can result in
  incorrect compilation.

  * Add test23514.d

  * Enable optimization in test

  * Improve test case

  * Use ulong instead of size_t

  * Restrict test to 64-bit targets

  * Re-enable test for 32-bit targets

  * Disable test for win64 and add comment

https://github.com/dlang/dmd/pull/14904

--