https://issues.dlang.org/show_bug.cgi?id=17167

Atila Neves <atila.neves@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |blocker

--

https://issues.dlang.org/show_bug.cgi?id=17167

--- Comment #10 from Dlang Bot <dlang-bot@dlang.rocks> ---
@Geod24 updated dlang/dmd pull request #13828 "Simplify `Module.read` and its interaction with `FileManager`" mentioning this issue:

- Windows: Make FileName.exists correctly work with long path

  While attempting to refactor Module.read not to call 'File.read' twice,
  test17167 started to fail. The only possible difference was that
  the first File.read call was conditional on FileName.exists succeeding,
  while the second call was inconditional.
  After a bit of research, it turns out that the fix for issue 17167
  was apparently missing one key detail (the prefix) to enable long path.
  This was not visible at the time because the fix for File.read was complete,
  and so the second attempt would succeed, hiding the issue.

https://github.com/dlang/dmd/pull/13828

--

https://issues.dlang.org/show_bug.cgi?id=17167

--- Comment #11 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #13828 "Simplify `Module.read` and its interaction with `FileManager`" was merged into master:

- 8f2a7b139fa06fe3c36c0598ddc114c331d581f6 by Geod24:
  Windows: Make FileName.exists correctly work with long path

  While attempting to refactor Module.read not to call 'File.read' twice,
  test17167 started to fail. The only possible difference was that
  the first File.read call was conditional on FileName.exists succeeding,
  while the second call was inconditional.

  After a bit of research, it turns out that the fix for issue 17167
  was apparently missing one key detail (the prefix) to enable long path.
  This was not visible at the time because the fix for File.read was complete,
  and so the second attempt would succeed, hiding the issue.

  This brings into question the correctness / need for toWStringzThen,
  as it's mostly used for long path, and is still being used in cannonicalName.

https://github.com/dlang/dmd/pull/13828

--

https://issues.dlang.org/show_bug.cgi?id=17167

RazvanN <razvan.nitu1305@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
                 CC|                            |razvan.nitu1305@gmail.com
         Resolution|---                         |FIXED

--