I'm now finally ready to upstream all ARM changes, but I'm not sure where the changes with ARM ASM code should be upstreamed to:

This stuff is not compatible with LDC/DMD.
Should I place those ASM blocks in a version(GNU) block and push those
changes to upstream druntime/test suite upstream?
https://github.com/jpf91/GDC/commit/15bfae2b04928e1797729a04b9e67b3cff7ae0e6
https://github.com/jpf91/GDC/commit/f7bafdd7b6b323012bf78aa53b969fff718e68e3

Or should I just push these into the GDC repo only?

On 14 January 2014 14:45, Johannes Pfau <nospam@example.com> wrote:
> I'm now finally ready to upstream all ARM changes, but I'm not sure where the changes with ARM ASM code should be upstreamed to:
>
> This stuff is not compatible with LDC/DMD.
> Should I place those ASM blocks in a version(GNU) block and push those
> changes to upstream druntime/test suite upstream?
> https://github.com/jpf91/GDC/commit/15bfae2b04928e1797729a04b9e67b3cff7ae0e6
> https://github.com/jpf91/GDC/commit/f7bafdd7b6b323012bf78aa53b969fff718e68e3
>
> Or should I just push these into the GDC repo only?

I don't think upstream will like GDC-specific code in the testsuite/library. ;-)

The changes that do not include extended assembler look fine to push upstream.

Regards
Iain

On 14/01/14 16:49, Iain Buclaw wrote:
> I don't think upstream will like GDC-specific code in the testsuite/library. ;-)
>
> The changes that do not include extended assembler look fine to push upstream.

How does this fit with the goal of common frontend for all compilers?  Or is this part of what will be glue code?

On 14 Jan 2014 17:45, "Joseph Rushton Wakeling" < joseph.wakeling@webdrake.net> wrote:
>
> On 14/01/14 16:49, Iain Buclaw wrote:
>>
>> I don't think upstream will like GDC-specific code in the
testsuite/library. ;-)
>>
>> The changes that do not include extended assembler look fine to push
upstream.
>
>
> How does this fit with the goal of common frontend for all compilers?  Or
is this part of what will be glue code?
>

In relation to these patches. That is something completely other.

Am Tue, 14 Jan 2014 15:45:02 +0100
schrieb Johannes Pfau <nospam@example.com>:

> I'm now finally ready to upstream all ARM changes, but I'm not sure where the changes with ARM ASM code should be upstreamed to:
> 
> This stuff is not compatible with LDC/DMD.
> Should I place those ASM blocks in a version(GNU) block and push those
> changes to upstream druntime/test suite upstream?
> https://github.com/jpf91/GDC/commit/15bfae2b04928e1797729a04b9e67b3cff7ae0e6
> https://github.com/jpf91/GDC/commit/f7bafdd7b6b323012bf78aa53b969fff718e68e3
> 
> Or should I just push these into the GDC repo only?

OK, all upstream pull requests filed:

Phobos: https://github.com/D-Programming-Language/phobos/pull/1863 https://github.com/D-Programming-Language/phobos/pull/1862 https://github.com/D-Programming-Language/phobos/pull/1861 https://github.com/D-Programming-Language/phobos/pull/1860 https://github.com/D-Programming-Language/phobos/pull/1859

Druntime: https://github.com/D-Programming-Language/druntime/pull/709 https://github.com/D-Programming-Language/druntime/pull/710

DMD: https://github.com/D-Programming-Language/dmd/pull/3093