Thread overview
[Issue 24078] [REG] crash related to concatenation
Aug 09, 2023
naydef
Aug 09, 2023
Basile-z
Aug 10, 2023
Basile-z
Aug 19, 2023
Dlang Bot
Aug 19, 2023
Dlang Bot
Sep 16, 2023
Dlang Bot
August 09, 2023
https://issues.dlang.org/show_bug.cgi?id=24078

naydef <naydef@abv.bg> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |naydef@abv.bg

--- Comment #1 from naydef <naydef@abv.bg> ---
Digger blames https://github.com/dlang/dmd/pull/14550

--
August 09, 2023
https://issues.dlang.org/show_bug.cgi?id=24078

Basile-z <b2.temp@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|wrong-code                  |

--
August 10, 2023
https://issues.dlang.org/show_bug.cgi?id=24078

--- Comment #2 from Basile-z <b2.temp@gmx.com> ---
reduced w/o phobos

```
extern(C) int puts(const char*);

void main()
{
    auto a = ["c\0"];
    foreach (v; a ~ "a\0" ~ "b\0")
        puts(v.ptr);
}
```

--
August 19, 2023
https://issues.dlang.org/show_bug.cgi?id=24078

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #3 from Dlang Bot <dlang-bot@dlang.rocks> ---
@teodutu created dlang/dmd pull request #15543 "Fix Issue 24078 - Fold constants on array concatenation only for strings" fixing this issue:

- Fix Issue 24078 - Fold constants on array concatenation only for strings

  Without this limitation, the code could incorrectly concatenate
  `["c"] ~ "a" ~ "b"` as `["c"] ~ "ab"`, which was incorrect.

  Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>

https://github.com/dlang/dmd/pull/15543

--
August 19, 2023
https://issues.dlang.org/show_bug.cgi?id=24078

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #15543 "Fix Issue 24078 - Fold constants on array concatenation only for strings" was merged into stable:

- c0de9a32d21bd15ca3ca4c0baaea3a6844122e2d by Teodor Dutu:
  Fix Issue 24078 - Fold constants on array concatenation only for strings

  Without this limitation, the code could incorrectly concatenate
  `["c"] ~ "a" ~ "b"` as `["c"] ~ "ab"`, which was incorrect.

  Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>

https://github.com/dlang/dmd/pull/15543

--
September 16, 2023
https://issues.dlang.org/show_bug.cgi?id=24078

--- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #15609 "merge stable" was merged into master:

- b349b6d0de9d375bda2db418fb16fabe7fc2f031 by Teodor Dutu:
  Fix Issue 24078 - Fold constants on array concatenation only for strings

  Without this limitation, the code could incorrectly concatenate
  `["c"] ~ "a" ~ "b"` as `["c"] ~ "ab"`, which was incorrect.

  Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>

https://github.com/dlang/dmd/pull/15609

--