Thread overview
[Issue 19498] undefined identifier rt_loadLibraryW
Dec 19, 2018
Walter Bright
Dec 19, 2018
Walter Bright
Dec 20, 2018
Eduard Staniloiu
Dec 20, 2018
Eduard Staniloiu
Dec 30, 2018
Seb
December 19, 2018
https://issues.dlang.org/show_bug.cgi?id=19498

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@digitalmars.com

--- Comment #1 from Walter Bright <bugzilla@digitalmars.com> ---
wchar_t should not be used in D code unless it is directly interfacing with C++ code that uses wchar_t in its parameter list.

The bug here is that core\druntime.d is calling a D function rt_loadLibraryW() which is obsoletely using wchar_t in its signature.

The fix is to use WCHAR instead and fix rt\dmain2.d to use WCHAR.

--
December 19, 2018
https://issues.dlang.org/show_bug.cgi?id=19498

--- Comment #2 from Walter Bright <bugzilla@digitalmars.com> ---
The files in question:

    rt\dmain2.d
    core\runtime.d

There's no reason to ever use the "A" Windows functions anymore, as Windows 95 is long dead.

1. delete rt_loadLibraryW()

2. move the logic in loadLibrary() to rt_loadLibrary()

--
December 20, 2018
https://issues.dlang.org/show_bug.cgi?id=19498

Eduard Staniloiu <edi33416@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |edi33416@gmail.com

--- Comment #3 from Eduard Staniloiu <edi33416@gmail.com> ---
https://github.com/dlang/druntime/pull/2414

--
December 20, 2018
https://issues.dlang.org/show_bug.cgi?id=19498

Eduard Staniloiu <edi33416@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@puremagic.com        |edi33416@gmail.com

--
December 30, 2018
https://issues.dlang.org/show_bug.cgi?id=19498

Seb <greeenify@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |greeenify@gmail.com
         Resolution|---                         |FIXED

--- Comment #4 from Seb <greeenify@gmail.com> ---
Rainer's PR has been merged.

--
January 02, 2019
https://issues.dlang.org/show_bug.cgi?id=19498

--- Comment #5 from github-bugzilla@puremagic.com ---
Commits pushed to master at https://github.com/dlang/druntime

https://github.com/dlang/druntime/commit/9f504a4f52e1442fd9497daefee83f61b378a817 fix issue 19498 - undefined identifier rt_loadLibraryW

restore definition to avoid breaking change for now

https://github.com/dlang/druntime/commit/c54593d256475b6c421b01bdfff958808ecadbaf Merge pull request #2425 from rainers/issue19498

fix issue 19498 - undefined identifier rt_loadLibraryW
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

--