https://issues.dlang.org/show_bug.cgi?id=18391

Adam D. Ruppe <destructionator@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |destructionator@gmail.com

--- Comment #1 from Adam D. Ruppe <destructionator@gmail.com> ---
I'd argue they kinda can by doing a palette swap in their console/terminal emulator... (the real WTF is most those ship with barely usable default palettes! that's one of the reasons why i wrote my own, not only to change the palette but to make it do adaptive contrast...)

--

https://issues.dlang.org/show_bug.cgi?id=18391

--- Comment #2 from Seb <greensunny12@gmail.com> ---
> I'd argue they kinda can by doing a palette swap in their console/terminal emulator.

Note that not all terminals are equal, my terminal has some issues with boldness:

https://github.com/dlang/dmd/pull/7822

Also, there are and always will be personal preferences.
Should dmd really use boldness for the keywords? Why not white? Or pink? etc.

This is highly subjective and I don't see any reason why it shouldn't be allowed.

--

https://issues.dlang.org/show_bug.cgi?id=18391

--- Comment #3 from Adam D. Ruppe <destructionator@gmail.com> ---
It's just more configuration that has to be coded, tested, documented, and actually used by the end user. Whereas knowing how to fix up your terminal palette will just work across all programs.

I remain of the opinion that this syntax highlighting is a mistake anyway, even if the implementation was free (which it isn't): it adds nothing of value and has an opportunity cost of watering down the potential of using careful color output in some other way later, but if it is here, even if it is configurable, the default has to be reasonable in 99% of cases since only 1% are likely to even be aware of such an option, much less actually set it.

So I'm not against adding the option per se, but I do caution against using the option to paper over the deficiencies of the default.

--

https://issues.dlang.org/show_bug.cgi?id=18391

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P4

--

https://issues.dlang.org/show_bug.cgi?id=18391

--- Comment #4 from dlangBugzillaToGithub <robert.schadek@posteo.de> ---
THIS ISSUE HAS BEEN MOVED TO GITHUB

https://github.com/dlang/dmd/issues/19384

DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB

--