[Issue 19091] __traits(compiles) and error in templated structs leads to missing symbol (page 2)

https://issues.dlang.org/show_bug.cgi?id=19091 moonlightsentinel@disroot.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |moonlightsentinel@disroot.o | |rg --- Comment #9 from moonlightsentinel@disroot.org --- (In reply to FeepingCreature from comment #7) > Unified with what I'm learning from the testcase from 21235: > > [...] Digger blames this PR: https://github.com/dlang/dmd/pull/544 --

https://issues.dlang.org/show_bug.cgi?id=19091 --- Comment #10 from FeepingCreature <default_357-line@yahoo.de> --- There's probably two issues. There's some sort of issue (which triggered this originally) where the same template is inferred @safe at one time and non-@safe in the other, which is what sent me off on 21235. But because the template error that would normally draw attention to this issue gets eaten and turned into a linker error, this is hard to differentiate from 19091 so I'd strongly recommend to get 19091 fixed first before even looking into the 21235 regression. --

https://issues.dlang.org/show_bug.cgi?id=19091 Dlang Bot <dlang-bot@dlang.rocks> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |pull --- Comment #11 from Dlang Bot <dlang-bot@dlang.rocks> --- @WalterBright created dlang/dmd pull request #12014 "fix Issue 19091 - __traits(compiles) and error in templated structs l…" fixing this issue: - fix Issue 19091 - __traits(compiles) and error in templated structs leads to missing symbol https://github.com/dlang/dmd/pull/12014 --

https://issues.dlang.org/show_bug.cgi?id=19091 Walter Bright <bugzilla@digitalmars.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://issues.dlang.org/sh | |ow_bug.cgi?id=19545 --

March 24, 2022

[Issue 19091] __traits(compiles) and error in templated structs leads to missing symbol

Posted by FeepingCreature

Permalink

FeepingCreature

Permalink

https://issues.dlang.org/show_bug.cgi?id=19091

--- Comment #12 from FeepingCreature <default_357-line@yahoo.de> ---
I have found a whole new manifestation of this bug!

struct Inner()
{
    bool opEquals(Inner) { }
}

struct Outer()
{
    Inner!() field;
    bool opEquals(Outer) { return field == field; }
}

void main()
{
    void nested()() { cast(void) Outer!()(); }

    static assert(__traits(compiles, nested()) == false);

    nested();
}

In 2.097.1, this results in an illegal instruction!

Building with master reveals that this is a compiled-out assert; it actually errors with

core.exception.AssertError@src/dmd/e2ir.d(529): Assertion failure
----------------
??:? _d_assertp [0x55a6c3d0d8bd]
src/dmd/e2ir.d:529 _ZN13ToElemVisitor5visitEP10Expression [0x55a6c3bbe899]
src/dmd/visitor.d:66 _ZN7Visitor5visitEP8ErrorExp [0x55a6c3baf006]
src/dmd/expression.d:2026 _ZN8ErrorExp6acceptEP7Visitor [0x55a6c3aca97d]
src/dmd/e2ir.d:504 _Z6toElemP10ExpressionP7IRState [0x55a6c3bbe7d3]
src/dmd/e2ir.d:411 _Z10toElemDtorP10ExpressionP7IRState [0x55a6c3bbe41c]
src/dmd/s2ir.d:728 _ZN11S2irVisitor5visitEP15ReturnStatement [0x55a6c3be9ee3]
src/dmd/statement.d:1430 _ZN15ReturnStatement6acceptEP7Visitor [0x55a6c3b7e1b1]
src/dmd/s2ir.d:1537
_ZN11S2irVisitor14Statement_toIREP9StatementP7IRStateP9StmtStateI5blockE
[0x55a6c3bec1c3]
src/dmd/s2ir.d:786 _ZN11S2irVisitor5visitEP17CompoundStatement [0x55a6c3bea127]
src/dmd/statement.d:620 _ZN17CompoundStatement6acceptEP7Visitor
[0x55a6c3b7c815]
src/dmd/s2ir.d:1557 _Z14Statement_toIRP9StatementP7IRState [0x55a6c3bec2bf]
src/dmd/glue.d:1100 _Z25FuncDeclaration_toObjFileP15FuncDeclarationb
[0x55a6c3be1430]
src/dmd/toobj.d:311 _ZN9toObjFile9ToObjFile5visitEP15FuncDeclaration
[0x55a6c3bf6a64]
src/dmd/func.d:2817 _ZN15FuncDeclaration6acceptEP7Visitor [0x55a6c3b09cdd]
src/dmd/toobj.d:534 void dmd.toobj.toObjFile(dmd.dsymbol.Dsymbol,
bool).ToObjFile.visit(dmd.dstruct.StructDeclaration).__lambda2!(dmd.dsymbol.Dsymbol).__lambda2(dmd.dsymbol.Dsymbol)
[0x55a6c3bf7251]
src/dmd/dsymbol.d:105 void
dmd.dsymbol.foreachDsymbol(dmd.root.array.Array!(dmd.dsymbol.Dsymbol).Array*,
void delegate(dmd.dsymbol.Dsymbol)) [0x55a6c3a8739f]
src/dmd/toobj.d:534 _ZN9toObjFile9ToObjFile5visitEP17StructDeclaration
[0x55a6c3bf719e]
src/dmd/dstruct.d:451 _ZN17StructDeclaration6acceptEP7Visitor [0x55a6c3a86c6d]
src/dmd/toobj.d:827 void dmd.toobj.toObjFile(dmd.dsymbol.Dsymbol,
bool).ToObjFile.visit(dmd.dtemplate.TemplateInstance).__lambda2!(dmd.dsymbol.Dsymbol).__lambda2(dmd.dsymbol.Dsymbol)
[0x55a6c3bf7b35]
src/dmd/dsymbol.d:105 void
dmd.dsymbol.foreachDsymbol(dmd.root.array.Array!(dmd.dsymbol.Dsymbol).Array*,
void delegate(dmd.dsymbol.Dsymbol)) [0x55a6c3a8739f]
src/dmd/toobj.d:827 _ZN9toObjFile9ToObjFile5visitEP16TemplateInstance
[0x55a6c3bf7b0e]
src/dmd/dtemplate.d:7504 _ZN16TemplateInstance6acceptEP7Visitor
[0x55a6c3ab4cd1]
src/dmd/toobj.d:1008 _Z9toObjFileP7Dsymbolb [0x55a6c3bf69ca]
src/dmd/glue.d:522 _Z10genObjFileP6Moduleb [0x55a6c3bdf9d3]
src/dmd/glue.d:137 void dmd.glue.generateCodeAndWrite(dmd.dmodule.Module[],
const(char)*[], const(char)[], const(char)[], bool, bool, bool, bool, bool)
[0x55a6c3bde396]
src/dmd/mars.d:571 int dmd.mars.tryMain(ulong, const(char)**, ref
dmd.globals.Param) [0x55a6c39f92a5]
src/dmd/mars.d:953 _Dmain [0x55a6c39fa851]

--

https://issues.dlang.org/show_bug.cgi?id=19091 --- Comment #13 from FeepingCreature <default_357-line@yahoo.de> --- Oh yeah, the missing printf I forgot to paste: [] error: __error Ie. considering printf("[%s] %s: %s\n", e.loc.toChars(), EXPtoString(e.op).ptr, e.toChars()); meaning e, probably the opEquals, was in an errored state and we never reported the error and tried to emit it regardless. --

https://issues.dlang.org/show_bug.cgi?id=19091 --- Comment #14 from FeepingCreature <default_357-line@yahoo.de> --- Hm, this one seems to be distinctive enough that I should report it as a new one. Sorry, it smelled familiar. But the assert seems its own problem site. Re-filed as https://issues.dlang.org/show_bug.cgi?id=22917 --

https://issues.dlang.org/show_bug.cgi?id=19091 Iain Buclaw <ibuclaw@gdcproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 |P3 --

https://issues.dlang.org/show_bug.cgi?id=19091 --- Comment #15 from dlangBugzillaToGithub <robert.schadek@posteo.de> --- THIS ISSUE HAS BEEN MOVED TO GITHUB https://github.com/dlang/dmd/issues/17870 DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB --

Forums