https://issues.dlang.org/show_bug.cgi?id=23692

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |accepts-invalid, ImportC
           See Also|                            |https://issues.dlang.org/sh
                   |                            |ow_bug.cgi?id=23689
         Depends on|                            |23689


Referenced Issues:

https://issues.dlang.org/show_bug.cgi?id=23689
[Issue 23689] ImportC: C tests in the testsuite are not valid C
--

https://issues.dlang.org/show_bug.cgi?id=23692

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ibuclaw@gdcproject.org

--- Comment #1 from Iain Buclaw <ibuclaw@gdcproject.org> ---
Some observations:

1. It would appear that `__pragma` and `__declspec` are MSVC extensions.

2. There is no documentation of ImportC parser handling these.

https://dlang.org/spec/importc.html#visualc-extensions

As of writing the this is an empty paragraph

```
<h2>$(LNAME2 visualc-extensions, Visual C Extensions)</h2>
$(DDOC_BLANKLINE )
$(DDOC_BLANKLINE )
<h2>$(LNAME2 digital-mars-extensions, Digital Mars C Extensions)</h2>
```

--

https://issues.dlang.org/show_bug.cgi?id=23692

Walter Bright <bugzilla@digitalmars.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla@digitalmars.com

--- Comment #2 from Walter Bright <bugzilla@digitalmars.com> ---
(In reply to Iain Buclaw from comment #1)
> 1. It would appear that `__pragma` and `__declspec` are MSVC extensions.

That's correct. Just like ImportC adds extensions to try to get gcc .h files to compile.

--

https://issues.dlang.org/show_bug.cgi?id=23692

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|dmd                         |dlang.org
            Summary|compilable/test22724.i:4:10 |ImportC: __pragma and
                   |: error: unknown type name  |__declspec are not
                   |'pack'                      |documented as supported
                   |                            |Visual C extensions

--

https://issues.dlang.org/show_bug.cgi?id=23692

--- Comment #3 from Iain Buclaw <ibuclaw@gdcproject.org> ---
(In reply to Walter Bright from comment #2)
> (In reply to Iain Buclaw from comment #1)
> > 1. It would appear that `__pragma` and `__declspec` are MSVC extensions.
> 
> That's correct. Just like ImportC adds extensions to try to get gcc .h files to compile.
OK, updated title and switched component over to dlang.org.

--

https://issues.dlang.org/show_bug.cgi?id=23692

Iain Buclaw <ibuclaw@gdcproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P2

--

https://issues.dlang.org/show_bug.cgi?id=23692

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
@WalterBright created dlang/dlang.org pull request #3622 "fix Issue 23692 - ImportC: __pragma and __declspec are not documented…" fixing this issue:

- fix Issue 23692 - ImportC: __pragma and __declspec are not documented as supported Visual C extensions

https://github.com/dlang/dlang.org/pull/3622

--

https://issues.dlang.org/show_bug.cgi?id=23692

--- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> ---
@WalterBright created dlang/dlang.org pull request #3623 "fix Issue 23692 - ImportC: __pragma and __declspec are not documented…" fixing this issue:

- fix Issue 23692 - ImportC: __pragma and __declspec are not documented as supported Visual C extensions

https://github.com/dlang/dlang.org/pull/3623

--

https://issues.dlang.org/show_bug.cgi?id=23692

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dlang.org pull request #3622 "fix Issue 23692 - ImportC: __pragma and __declspec are not documented…" was merged into master:

- 72d897dfb26fed34ec65b2d21c87e6cadf90ecff by Walter Bright:
  fix Issue 23692 - ImportC: __pragma and __declspec are not documented as
supported Visual C extensions

https://github.com/dlang/dlang.org/pull/3622

--

https://issues.dlang.org/show_bug.cgi?id=23692
Issue 23692 depends on issue 23689, which changed state.

Issue 23689 Summary: ImportC: C tests in the testsuite are not valid C https://issues.dlang.org/show_bug.cgi?id=23689

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--