On Tuesday, 1 November 2022 at 10:22:17 UTC, rikki cattermole wrote:
> Hey,
>
> As you know, I'm currently working on the table generator trying to get that into Phobos, and its been a fair amount of work for what should have already been working (oh wells).
>

Totally understand the feeling. Keep in mind that I'm in the same position today.

> I did have to recreate some logic for the symbols toUpperSimpleIndex and friends.

When I tried to restore tables before I opted to remove them, not sure if it was the right move. https://github.com/dlang/phobos/pull/7469

>
> My general feeling is I'm missing something as I'm getting:
>
> https://dev.azure.com/dlanguage/Phobos/_build/results?buildId=33558&view=logs&j=4fbced83-508e-5fe0-c978-5c71ec0fc506&t=efea9dc6-8b7a-5cfd-995a-4727b0e8449d&l=4640
>

Cannot easily decipher what's blowing up there. Seems to be this:

 Error: `assert(cmp(s2, "I i\xcc\x87") == 0)` failed

I'm missing the context but it looks like this uses title case tables which are not the same as simple case folding, but since you didn't fiddle with title case that would be strange to break.

> I did that logic by hand, I'm pretty certain it should be working, my suspicion is you had it do the decomposing as well. I could do with some pointers on what is probably missing for #12455 as those changes never made it into the repo for the generator.

So the issue with simple case folding vs full case folding. Simple case folding is used mostly in sicmp (simple insensitive cmp) so should be well confined.


In any case I'm happy to help with restoring the generator, could you point me to your repo so I can help you figure out what might be missing?

On 02/11/2022 12:01 AM, Dmitry Olshansky wrote:
> On Tuesday, 1 November 2022 at 10:22:17 UTC, rikki cattermole wrote:
>> Hey,
>>
>> As you know, I'm currently working on the table generator trying to get that into Phobos, and its been a fair amount of work for what should have already been working (oh wells).
>>
> 
> Totally understand the feeling. Keep in mind that I'm in the same position today.

I chose not to raise it with you because 2014 was a long time ago, no chance you still have it ;)

But I am on my second day, so I'm hoping you'll at least know what I need to do.

>> I did have to recreate some logic for the symbols toUpperSimpleIndex and friends.
> 
> When I tried to restore tables before I opted to remove them, not sure if it was the right move. https://github.com/dlang/phobos/pull/7469
> 
>>
>> My general feeling is I'm missing something as I'm getting:
>>
>> https://dev.azure.com/dlanguage/Phobos/_build/results?buildId=33558&view=logs&j=4fbced83-508e-5fe0-c978-5c71ec0fc506&t=efea9dc6-8b7a-5cfd-995a-4727b0e8449d&l=4640
>>
> 
> Cannot easily decipher what's blowing up there. Seems to be this:
> 
>   Error: `assert(cmp(s2, "I i\xcc\x87") == 0)` failed
> 
> I'm missing the context but it looks like this uses title case tables which are not the same as simple case folding, but since you didn't fiddle with title case that would be strange to break.

Yes this has something to do with casing, rather than case folding. It does need SpecialCasing.txt. The check in question shouldn't have anything to do with case folding as it is ``cmp``.

>> I did that logic by hand, I'm pretty certain it should be working, my suspicion is you had it do the decomposing as well. I could do with some pointers on what is probably missing for #12455 as those changes never made it into the repo for the generator.
> 
> So the issue with simple case folding vs full case folding. Simple case folding is used mostly in sicmp (simple insensitive cmp) so should be well confined.
> 
> 
> In any case I'm happy to help with restoring the generator, could you point me to your repo so I can help you figure out what might be missing?

https://github.com/rikkimax/phobos/blob/unicode_tables/std/internal/unicode_table_generator.d#L575

https://github.com/rikkimax/phobos/blob/unicode_tables/std/internal/unicode_table_generator.d#L868

On Tuesday, 1 November 2022 at 11:11:05 UTC, rikki cattermole wrote:
> On 02/11/2022 12:01 AM, Dmitry Olshansky wrote:
>> On Tuesday, 1 November 2022 at 10:22:17 UTC, rikki cattermole
>>>
>> 
>> 
>> In any case I'm happy to help with restoring the generator, could you point me to your repo so I can help you figure out what might be missing?
>
> https://github.com/rikkimax/phobos/blob/unicode_tables/std/internal/unicode_table_generator.d#L575
>
> https://github.com/rikkimax/phobos/blob/unicode_tables/std/internal/unicode_table_generator.d#L868

Okay that's a start) Just in case - I pushed important tiny fix to my repo you should absolutely take it, has to do with property name aliases incorrectly swapped.

In general, I think we should take this discussion to some messenger so as to not flood the forums. I recall you had discord or something.

On 02/11/2022 1:21 AM, Dmitry Olshansky wrote:
> Okay that's a start) Just in case - I pushed important tiny fix to my repo you should absolutely take it, has to do with property name aliases incorrectly swapped.

Yeah, already grabbed it as soon as I saw it.

> In general, I think we should take this discussion to some messenger so as to not flood the forums. I recall you had discord or something.

Yeah Discord works.

On Tuesday, 1 November 2022 at 12:27:13 UTC, rikki cattermole wrote:
> On 02/11/2022 1:21 AM, Dmitry Olshansky wrote:
>> Okay that's a start) Just in case - I pushed important tiny fix to my repo you should absolutely take it, has to do with property name aliases incorrectly swapped.
>
> Yeah, already grabbed it as soon as I saw it.
>
>> In general, I think we should take this discussion to some messenger so as to not flood the forums. I recall you had discord or something.
>
> Yeah Discord works.

Please elaborate how do I find you there, been ages since I used it.

On 02/11/2022 1:40 AM, Dmitry Olshansky wrote:
> On Tuesday, 1 November 2022 at 12:27:13 UTC, rikki cattermole wrote:
>> On 02/11/2022 1:21 AM, Dmitry Olshansky wrote:
>>> Okay that's a start) Just in case - I pushed important tiny fix to my repo you should absolutely take it, has to do with property name aliases incorrectly swapped.
>>
>> Yeah, already grabbed it as soon as I saw it.
>>
>>> In general, I think we should take this discussion to some messenger so as to not flood the forums. I recall you had discord or something.
>>
>> Yeah Discord works.
> 
> Please elaborate how do I find you there, been ages since I used it.

For future reference: dlang.org -> community -> Community Discord

https://discord.gg/bMZk9Q4

On 03/11/2022 12:20 AM, Hipreme wrote:
> The greatest bug on std.regex is it being too slow to compile, do you have any idea on what it could be right now? Are you looking for fixes or an entire rework on it?

A feature that is known to have been useless is ctRegex, that needs to be deprecated. Perhaps that'll help things once removed?

On Wednesday, 2 November 2022 at 11:34:11 UTC, rikki cattermole wrote:
> On 03/11/2022 12:20 AM, Hipreme wrote:
>> The greatest bug on std.regex is it being too slow to compile, do you have any idea on what it could be right now? Are you looking for fixes or an entire rework on it?
>
> A feature that is known to have been useless is ctRegex, that needs to be deprecated. Perhaps that'll help things once removed?

Yeah, that should be removed