June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to Vladimir Panteleev | On Thursday, 4 June 2015 at 15:04:05 UTC, Vladimir Panteleev wrote: > http://beta.forum.dlang.org/ > > Many major and minor improvements. > > Some major ones: > > - dlang.org theme, fully responsive and mobile-friendly > - keyboard navigation in all views > - automatically saved post drafts > - get notified of new posts and replies with subscriptions > - full text search > - by persistent request, a new view mode (vertical-split) > - post to mailing lists > - even faster, believe it or not. > > This update is the sum of 256 commits over 34 days of development. Re:, Re: everywhere. http://i.imgur.com/tzRpnqR.png |
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to Vladimir Panteleev | On Thursday, 4 June 2015 at 20:08:04 UTC, Vladimir Panteleev wrote:
> On Thursday, 4 June 2015 at 20:06:10 UTC, Tourist wrote:
>> On Thursday, 4 June 2015 at 19:42:09 UTC, Vladimir Panteleev wrote:
>>> On Thursday, 4 June 2015 at 17:57:26 UTC, Mr. Anonymous wrote:
>>>> * No threaded view?
>>>
>>> There are 4 view modes:
>>>
>>> http://beta.forum.dlang.org/help#view-modes
>>
>> I liked this:
>> http://i.imgur.com/M1nLVkr.png
>>
>> Now it can only be changed from settings, right?
>
> Yes. How often do you change view modes?
It's OK as is, I was just used to it being there.
|
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to Tourist | On Thursday, 4 June 2015 at 20:16:01 UTC, Tourist wrote:
> On Thursday, 4 June 2015 at 20:08:04 UTC, Vladimir Panteleev wrote:
>> On Thursday, 4 June 2015 at 20:06:10 UTC, Tourist wrote:
>>> On Thursday, 4 June 2015 at 19:42:09 UTC, Vladimir Panteleev wrote:
>>>> On Thursday, 4 June 2015 at 17:57:26 UTC, Mr. Anonymous wrote:
>>>>> * No threaded view?
>>>>
>>>> There are 4 view modes:
>>>>
>>>> http://beta.forum.dlang.org/help#view-modes
>>>
>>> I liked this:
>>> http://i.imgur.com/M1nLVkr.png
>>>
>>> Now it can only be changed from settings, right?
>>
>> Yes. How often do you change view modes?
>
> It's OK as is, I was just used to it being there.
I should add that the view mode is now always saved in a cookie, even if you're registered. This means that if you used one view mode on your PC and one on your phone, you won't need to switch them around every time.
|
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to Vladimir Panteleev | On Thursday, 4 June 2015 at 20:05:32 UTC, Vladimir Panteleev wrote: > On Thursday, 4 June 2015 at 19:57:20 UTC, sigod wrote: >> On Thursday, 4 June 2015 at 19:42:09 UTC, Vladimir Panteleev wrote: >>> On Thursday, 4 June 2015 at 17:57:26 UTC, Mr. Anonymous wrote: >>>> * Space to scroll doesn't work. >>> >>> Where? >> >> In threads. But works on help page. > > Should be fixed now. Yes. It works now. Few issues with help dialog (opened with Shift+H): - Centers on full page instead of only visible part of it. - Scrolls with page. On Thursday, 4 June 2015 at 20:07:26 UTC, Vladimir Panteleev wrote: > On Thursday, 4 June 2015 at 19:55:28 UTC, sigod wrote: >> Shift+? returns key code 191. And `String.fromCodePoint(191) === '¿'`. > > I looked into this. > > 191 is actually the code for the '/' key. This means that checking for it doesn't work on layouts where the question mark is typed by pressing another button. Does this work for you? I tried it on the Russian layout (where it's on Shift+7) and it doesn't. > > I settled by moving the help key to Shift+H. Well. Shift+/ works on GitHub and StackOverflow. As do Shift+7 on Russian layout. You can find line like this in GitHub's sources: `i={...,191:"?",...}`. So, I suppose it's better to use key codes directly. |
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to Vladimir Panteleev | On Thursday, 4 June 2015 at 20:07:26 UTC, Vladimir Panteleev wrote:
> On Thursday, 4 June 2015 at 19:55:28 UTC, sigod wrote:
>> On Thursday, 4 June 2015 at 15:38:57 UTC, Vladimir Panteleev wrote:
>>> On Thursday, 4 June 2015 at 15:33:56 UTC, extrawurst wrote:
>>>> [...]
>>>
>>> Code in question: https://github.com/CyberShadow/DFeed/blob/next/web/static/js/dfeed.js#L645-L646
>>>
>>> Can you propose a patch?
>>>
>>
>> Shift+? returns key code 191. And `String.fromCodePoint(191) === '¿'`.
>
> I looked into this.
>
> 191 is actually the code for the '/' key. This means that checking for it doesn't work on layouts where the question mark is typed by pressing another button. Does this work for you? I tried it on the Russian layout (where it's on Shift+7) and it doesn't.
>
> I settled by moving the help key to Shift+H.
Hm. Actually 63 key code will appear on `keypress` event. And 191 on `keydown`. (But you use `keydown` for webkit.)
|
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to sigod | On Thursday, 4 June 2015 at 20:30:38 UTC, sigod wrote: > On Thursday, 4 June 2015 at 20:07:26 UTC, Vladimir Panteleev wrote: >> On Thursday, 4 June 2015 at 19:55:28 UTC, sigod wrote: >>> On Thursday, 4 June 2015 at 15:38:57 UTC, Vladimir Panteleev wrote: >>>>[...] >>> >>> Shift+? returns key code 191. And `String.fromCodePoint(191) === '¿'`. >> >> I looked into this. >> >> 191 is actually the code for the '/' key. This means that checking for it doesn't work on layouts where the question mark is typed by pressing another button. Does this work for you? I tried it on the Russian layout (where it's on Shift+7) and it doesn't. >> >> I settled by moving the help key to Shift+H. > > Hm. Actually 63 key code will appear on `keypress` event. And 191 on `keydown`. (But you use `keydown` for webkit.) Take a look here: http://stackoverflow.com/a/29494190/944911 |
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to sigod | On Thursday, 4 June 2015 at 20:33:29 UTC, sigod wrote:
> On Thursday, 4 June 2015 at 20:30:38 UTC, sigod wrote:
>> Hm. Actually 63 key code will appear on `keypress` event. And 191 on `keydown`. (But you use `keydown` for webkit.)
>
> Take a look here: http://stackoverflow.com/a/29494190/944911
Thanks, I figured it out as well. Fix pushed.
|
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to Vladimir Panteleev | On Thursday, 4 June 2015 at 20:25:02 UTC, sigod wrote: > Few issues with help dialog (opened with Shift+H): > - Centers on full page instead of only visible part of it. > - Scrolls with page. `fixed` instead of [`absolute`][0] and it should be fixed. (Heh, funny.) Also, I believe closing popup on `mouseup` in popup itself doesn't create good UX. Better to close it on `click` outside of popup (maybe difficult to implement without overlay) and to provide an "X" (close) button in popup. [0]: https://github.com/CyberShadow/DFeed/blob/next/web/static/css/dfeed.css#L898 |
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to sigod | On Thursday, 4 June 2015 at 20:56:33 UTC, sigod wrote: > On Thursday, 4 June 2015 at 20:25:02 UTC, sigod wrote: >> Few issues with help dialog (opened with Shift+H): >> - Centers on full page instead of only visible part of it. >> - Scrolls with page. > > `fixed` instead of [`absolute`][0] and it should be fixed. (Heh, funny.) Thanks, fixed. > Also, I believe closing popup on `mouseup` in popup itself doesn't create good UX. Better to close it on `click` outside of popup (maybe difficult to implement without overlay) and to provide an "X" (close) button in popup. Yes, you're right. The popup isn't a big part of the UI, however, and you can dismiss it by pressing any key. |
June 04, 2015 Re: forum.dlang.org, version 2 (BETA) | ||||
---|---|---|---|---|
| ||||
Posted in reply to Vladimir Panteleev | Am 04.06.2015 um 17:43 schrieb Vladimir Panteleev:
> On Thursday, 4 June 2015 at 15:35:58 UTC, Nick Sabalausky wrote:
>> On 06/04/2015 11:14 AM, Vladimir Panteleev wrote:
>>>
>>> I thought of migrating to Vibe eventually, but it would be
>>> non-trivial.
>>> Some things the forum does are also difficult to express using
>>> the fiber
>>> asynchronicity model.
>>
>> Such as what? (Out of curiosity)
>
> One problem I ran into is with the NNTP client, which uses a pipeline
> queue of at most 64 commands. This means that it sends 64 commands to
> the server in one go, and as soon as it receives the reply to the first,
> it sends a 65th command.
>
> I don't know how things are now, but when I tried to move to Vibe.d
> (which was several years ago), you had to do some strange acrobatics in
> order to read the same connection in one fiber but write to it from
> another. In ae.net, reads are handled by callbacks, and all writes are
> delayed (data is queued and sent when the socket loop says the socket is
> writable), which means there is no contention and you can "write" to any
> socket from anywhere in the program (as long as it's in the same thread).
This has been solved in the meantime. Reads and writes can now occur concurrently in different fibers.
|
Copyright © 1999-2021 by the D Language Foundation