Thread overview | ||||||||
---|---|---|---|---|---|---|---|---|
|
October 01, 2016 [OT] google- and github-fu: how to search for a specific PR? | ||||
---|---|---|---|---|
| ||||
I was looking for the PR that changed iota.length and it took me longer than it could have. I googled for iota length dlang and among the top results I found the changelog PR: https://github.com/dlang/phobos/pull/4220, but it was through indirections via mail-archive.com. Same goes about the actual result (https://github.com/dlang/phobos/pull/4013) which was further down the page. Are there any shortcuts? It would help a lot if one could search github.com repos for PR titles, is that possible? Thanks, Andrei |
October 01, 2016 Re: [OT] google- and github-fu: how to search for a specific PR? | ||||
---|---|---|---|---|
| ||||
Posted in reply to Andrei Alexandrescu Attachments:
| On 10/01/2016 03:33 PM, Andrei Alexandrescu wrote: > I was looking for the PR that changed iota.length and it took me longer than it could have. I googled for > > iota length dlang > > and among the top results I found the changelog PR: https://github.com/dlang/phobos/pull/4220, but it was through indirections via mail-archive.com. Same goes about the actual result (https://github.com/dlang/phobos/pull/4013) which was further down the page. > > Are there any shortcuts? It would help a lot if one could search github.com repos for PR titles, is that possible? > > > Thanks, > > Andrei https://github.com/search?q=iota+length+dlang+&type=Issues&utf8=%E2%9C%93 Is that good enough? Relevant PR is the second entry there for me. |
October 02, 2016 Re: [OT] google- and github-fu: how to search for a specific PR? | ||||
---|---|---|---|---|
| ||||
Posted in reply to Andrei Alexandrescu | On 02/10/2016 1:33 AM, Andrei Alexandrescu wrote: > I was looking for the PR that changed iota.length and it took me longer > than it could have. I googled for > > iota length dlang > > and among the top results I found the changelog PR: > https://github.com/dlang/phobos/pull/4220, but it was through > indirections via mail-archive.com. Same goes about the actual result > (https://github.com/dlang/phobos/pull/4013) which was further down the > page. > > Are there any shortcuts? It would help a lot if one could search > github.com repos for PR titles, is that possible? > > > Thanks, > > Andrei https://github.com/dlang/phobos/search?utf8=%E2%9C%93&q=iota+length&type=Issues If we used more labels it would be easier still. This is also where integrated bug tracker can help significantly since its a commit message like "Fixes #1" would auto close issue once merged[0] and have it mentioned in both places. [0] https://help.github.com/articles/closing-issues-via-commit-messages/ |
October 01, 2016 Re: [OT] google- and github-fu: how to search for a specific PR? | ||||
---|---|---|---|---|
| ||||
Posted in reply to Andrei Alexandrescu | On Saturday, 1 October 2016 at 12:33:14 UTC, Andrei Alexandrescu wrote: > I was looking for the PR that changed iota.length and it took me longer than it could have. I googled for > Thanks, > > Andrei See also https://github.com/dlang/phobos/pull/4167 |
October 01, 2016 Re: [OT] google- and github-fu: how to search for a specific PR? | ||||
---|---|---|---|---|
| ||||
Posted in reply to Andrei Alexandrescu | On Saturday, 1 October 2016 at 12:33:14 UTC, Andrei Alexandrescu wrote: > Are there any shortcuts? Since the other answers have the fish, so I'll throw in (another) fishing rod: 1. Use `git blame` to find the commit you wish to find the PR of. (Since you use Emacs, magit's magit-blame is fantastic as always). 2. Concatenate "https://github.com/dlang/phobos/commit/" and the commit SHA1 to get the GitHub commit URL. 3. Click the pull request number below the commit message: https://dump.thecybershadow.net/9c86005610bf869873385d7ca6a76ee6/23%3A10%3A46-upload.png |
October 01, 2016 Re: [OT] google- and github-fu: how to search for a specific PR? | ||||
---|---|---|---|---|
| ||||
Posted in reply to Vladimir Panteleev | On 10/01/2016 07:15 PM, Vladimir Panteleev wrote:
> On Saturday, 1 October 2016 at 12:33:14 UTC, Andrei Alexandrescu wrote:
>> Are there any shortcuts?
>
> Since the other answers have the fish, so I'll throw in (another)
> fishing rod:
>
> 1. Use `git blame` to find the commit you wish to find the PR of. (Since
> you use Emacs, magit's magit-blame is fantastic as always).
>
> 2. Concatenate "https://github.com/dlang/phobos/commit/" and the commit
> SHA1 to get the GitHub commit URL.
>
> 3. Click the pull request number below the commit message:
> https://dump.thecybershadow.net/9c86005610bf869873385d7ca6a76ee6/23%3A10%3A46-upload.png
Thx to all! -- Andrei
|
Copyright © 1999-2021 by the D Language Foundation