Just made one more pass through it addressing concerns and adding a new policy (Throw). Reviews welcome. Let's get this through Scylla and Charybdis!

Code: https://github.com/dlang/phobos/pull/4613

Dox: http://dtest.thecybershadow.net/artifact/website-c1933a4611fdfd4f996f85d2f37a669f34d58d58-2020d60f92d3b96ef9c94dc8b38c7723/web/library-prerelease/std/experimental/checkedint.html

Docs: http://dtest.thecybershadow.net/artifact/website-c1933a4611fdfd4f996f85d2f37a669f34d58d58-2020d60f92d3b96ef9c94dc8b38c7723/web/phobos-prerelease/std_experimental_checkedint.html


Andrei

On Wednesday, 19 October 2016 at 17:09:35 UTC, Andrei Alexandrescu wrote:
> Just made one more pass through it addressing concerns and adding a new policy (Throw). Reviews welcome. Let's get this through Scylla and Charybdis!

> This module provides a few predefined hooks (below) that add useful behavior to Checked:

Missing Throw.

> Throw	Force all integral errors to fail by printing an error message to stderr and then abort the program. Abort is the default second argument for Checked.

Seems to be copy-pasted from Abort.

On 10/19/16 6:19 PM, Lurker wrote:
> On Wednesday, 19 October 2016 at 17:09:35 UTC, Andrei Alexandrescu wrote:
>> Just made one more pass through it addressing concerns and adding a
>> new policy (Throw). Reviews welcome. Let's get this through Scylla and
>> Charybdis!
>
>> This module provides a few predefined hooks (below) that add useful
>> behavior to Checked:
>
> Missing Throw.
>
>> Throw    Force all integral errors to fail by printing an error
>> message to stderr and then abort the program. Abort is the default
>> second argument for Checked.
>
> Seems to be copy-pasted from Abort.

Eh, it was indeed :o). Looking back I still see a few places in the documentation that I neglected. Will fix. The behavior is there. -- Andrei

On 10/19/2016 10:10 PM, Andrei Alexandrescu wrote:
> On 10/19/16 6:19 PM, Lurker wrote:
>> On Wednesday, 19 October 2016 at 17:09:35 UTC, Andrei Alexandrescu wrote:
>>> Just made one more pass through it addressing concerns and adding a
>>> new policy (Throw). Reviews welcome. Let's get this through Scylla and
>>> Charybdis!
>>
>>> This module provides a few predefined hooks (below) that add useful
>>> behavior to Checked:
>>
>> Missing Throw.
>>
>>> Throw    Force all integral errors to fail by printing an error
>>> message to stderr and then abort the program. Abort is the default
>>> second argument for Checked.
>>
>> Seems to be copy-pasted from Abort.
>
> Eh, it was indeed :o). Looking back I still see a few places in the
> documentation that I neglected. Will fix. The behavior is there. -- Andrei

Fixed the docs and a few more review items. Destruction welcome. -- Andrei