| Thread overview | ||||||||
|---|---|---|---|---|---|---|---|---|
|
July 09, 2012 [D-runtime] core.atomic | ||||
|---|---|---|---|---|
| ||||
 | The latest crashes on unittests on my windows box. The 2.059 one works.
_______________________________________________
D-runtime mailing list
D-runtime@puremagic.com
http://lists.puremagic.com/mailman/listinfo/d-runtime
| |||
Permalink
ReplyJuly 09, 2012 Re: [D-runtime] core.atomic | ||||
|---|---|---|---|---|
| ||||
 Posted in reply to Walter Bright | On Mon, Jul 9, 2012 at 11:34 AM, Walter Bright <walter@digitalmars.com> wrote: > The latest crashes on unittests on my windows box. The 2.059 one works. What exactly is failing? I'm almost certain it's the new atomicFence() function[1] blowing up, but need more info. The 32-bit version of it is rather complicated because it has to query the CPU for SSE2 support. I wrote it for cdecl on POSIX and it seems to work there, but something must be awry with the D calling convention on Windows... Do you spot anything obviously wrong? Regards, Alex [1] https://github.com/D-Programming-Language/druntime/blob/master/src/core/atomic.d#L585 _______________________________________________ D-runtime mailing list D-runtime@puremagic.com http://lists.puremagic.com/mailman/listinfo/d-runtime | |||
July 09, 2012 Re: [D-runtime] core.atomic | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Alex Rønne Petersen | You need a RET instruction on naked functions. On 7/9/2012 2:53 AM, Alex Rønne Petersen wrote: > On Mon, Jul 9, 2012 at 11:34 AM, Walter Bright <walter@digitalmars.com> wrote: >> The latest crashes on unittests on my windows box. The 2.059 one works. > What exactly is failing? I'm almost certain it's the new atomicFence() > function[1] blowing up, but need more info. > > The 32-bit version of it is rather complicated because it has to query > the CPU for SSE2 support. I wrote it for cdecl on POSIX and it seems > to work there, but something must be awry with the D calling > convention on Windows... Do you spot anything obviously wrong? > > Regards, > Alex > > [1] https://github.com/D-Programming-Language/druntime/blob/master/src/core/atomic.d#L585 > _______________________________________________ > D-runtime mailing list > D-runtime@puremagic.com > http://lists.puremagic.com/mailman/listinfo/d-runtime > > _______________________________________________ D-runtime mailing list D-runtime@puremagic.com http://lists.puremagic.com/mailman/listinfo/d-runtime | |||
July 09, 2012 Re: [D-runtime] core.atomic | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Walter Bright | Good point. I don't have a Windows box available to test on right now. Does it work on Windows if you add that after the Lend label? I just tested on Linux and tests pass with the change there. Regards, Alex On Mon, Jul 9, 2012 at 12:31 PM, Walter Bright <walter@digitalmars.com> wrote: > You need a RET instruction on naked functions. > > > On 7/9/2012 2:53 AM, Alex Rønne Petersen wrote: >> >> On Mon, Jul 9, 2012 at 11:34 AM, Walter Bright <walter@digitalmars.com> wrote: >>> >>> The latest crashes on unittests on my windows box. The 2.059 one works. >> >> What exactly is failing? I'm almost certain it's the new atomicFence() function[1] blowing up, but need more info. >> >> The 32-bit version of it is rather complicated because it has to query the CPU for SSE2 support. I wrote it for cdecl on POSIX and it seems to work there, but something must be awry with the D calling convention on Windows... Do you spot anything obviously wrong? >> >> Regards, >> Alex >> >> [1] >> https://github.com/D-Programming-Language/druntime/blob/master/src/core/atomic.d#L585 >> _______________________________________________ >> D-runtime mailing list >> D-runtime@puremagic.com >> http://lists.puremagic.com/mailman/listinfo/d-runtime >> >> > > > _______________________________________________ > D-runtime mailing list > D-runtime@puremagic.com > http://lists.puremagic.com/mailman/listinfo/d-runtime _______________________________________________ D-runtime mailing list D-runtime@puremagic.com http://lists.puremagic.com/mailman/listinfo/d-runtime | |||
July 09, 2012 Re: [D-runtime] core.atomic | ||||
|---|---|---|---|---|
| ||||
 Posted in reply to Walter Bright | On Mon, 09 Jul 2012 12:31:08 +0200, Walter Bright <walter@digitalmars.com> wrote: > You need a RET instruction on naked functions. > Sorry, that was on my checklist for the pull request but I should have added a comment when I first spotted it. _______________________________________________ D-runtime mailing list D-runtime@puremagic.com http://lists.puremagic.com/mailman/listinfo/d-runtime | |||
July 10, 2012 Re: [D-runtime] core.atomic | ||||
|---|---|---|---|---|
| ||||
Posted in reply to Martin Nowak | On Mon, Jul 9, 2012 at 6:19 PM, Martin Nowak <dawg@dawgfoto.de> wrote: > On Mon, 09 Jul 2012 12:31:08 +0200, Walter Bright <walter@digitalmars.com> wrote: > >> You need a RET instruction on naked functions. >> > Sorry, that was on my checklist for the pull request but I should have added a comment when I first spotted it. Submitted a fix: https://github.com/D-Programming-Language/druntime/pull/269 Sorry for the breakage... Regards, Alex _______________________________________________ D-runtime mailing list D-runtime@puremagic.com http://lists.puremagic.com/mailman/listinfo/d-runtime | |||
Copyright © 1999-2021 by the D Language Foundation