DMD backend quality (Was: Re: DIP 1031--Deprecate Brace-Style Struct Initializers--Community Review Round 1 Discussion) (page 3)

On Monday, 17 February 2020 at 05:11:14 UTC, Walter Bright wrote: > On 2/16/2020 7:02 PM, Adam D. Ruppe wrote: >> (my personal experience btw is that bugzilla is where issues go to be ignored, lost, or forgotten for years.) > > Anyone can submit PRs to fix bugzilla issues, including you. That doesn't mean they will get merged. There's lots of PR open that have been open for years without any sort of feedback. Why would anybody waste their free time to simply have their work ignored?

On 2/17/2020 10:45 AM, jxel wrote: > That doesn't mean they will get merged. There's lots of PR open that have been open for years without any sort of feedback. Why would anybody waste their free time to simply have their work ignored? The dmd compiler itself has 24,254 commits from 195 contributors. https://github.com/dlang/dmd Phobos has 17,927 commits from 367 contributors. https://github.com/dlang/phobos Druntime has 7,023 commits from 198 contributors. https://github.com/dlang/druntime

On 2/17/2020 12:25 AM, Jacob Carlborg wrote: > Apple has since long abandoned the GCC toolchain and now relies exclusively on the LLVM toolchain, as I've mentioned in several places on several occasions. That means Clang and LLDB. > > There are several issues reported for this: > > https://issues.dlang.org/show_bug.cgi?id=18527 > https://issues.dlang.org/show_bug.cgi?id=18612 > > You might want to search for "LLDB" as well: https://issues.dlang.org/buglist.cgi?quicksearch=lldb Thank you, you're right, I've never used LLDB. It never occurred to me that it would fail where gdb succeeds. They're both supposed to be compatible with dwarf. Anyhow, do you want to take a look at the dwarf output and see what's different? The dumpobj tool will pretty-print it.

On Sunday, 16 February 2020 at 00:16:24 UTC, H. S. Teoh wrote: > Of course, DMD is still very fast at compiling and useful for smaller utilities and script-like programs where performance isn't critical, or for running unittests for isolated modules during development due to fast turnaround times. But codegen quality is definitely not among the reasons I still use DMD. I still happily use DMD for most development because it still builds faster. (On Windows, try `dub -a x86 --compiler dmd` and see) But yes adding -O -inline frightens me. I think DMD should play its strength of generating code very quickly :) even at the expense of output performance.

On 2/17/2020 1:14 PM, Guillaume Piolat wrote: > I still happily use DMD for most development because it still builds faster. > (On Windows, try `dub -a x86 --compiler dmd` and see) > > But yes adding -O -inline frightens me. > I think DMD should play its strength of generating code very quickly :) even at the expense of output performance. No worries, there are no plans to change the fast path through the backend.

On Monday, 17 February 2020 at 19:35:53 UTC, Walter Bright wrote: > On 2/17/2020 10:45 AM, jxel wrote: >> That doesn't mean they will get merged. There's lots of PR open that have been open for years without any sort of feedback. Why would anybody waste their free time to simply have their work ignored? > > The dmd compiler itself has 24,254 commits from 195 contributors. > > https://github.com/dlang/dmd > > Phobos has 17,927 commits from 367 contributors. > > https://github.com/dlang/phobos > > Druntime has 7,023 commits from 198 contributors. > > https://github.com/dlang/druntime This gives somewhat an idea but actually these numbers, as provided by GH, are innaccurate, they don't include people who have left GH. If you really want to give numbers then you must use git to find the unique authors by email.

On Monday, 17 February 2020 at 19:35:53 UTC, Walter Bright wrote: > On 2/17/2020 10:45 AM, jxel wrote: >> That doesn't mean they will get merged. There's lots of PR open that have been open for years without any sort of feedback. Why would anybody waste their free time to simply have their work ignored? > > The dmd compiler itself has 24,254 commits from 195 contributors. > > https://github.com/dlang/dmd > > Phobos has 17,927 commits from 367 contributors. > > https://github.com/dlang/phobos > > Druntime has 7,023 commits from 198 contributors. > > https://github.com/dlang/druntime The contributions drop to single digits fairly quickly. People aren't coming back to contribute, I wonder why. Pointing to numbers doesn't mean there's are countless PR that are being neglected. All you are showing is that only the handful of people that can just ask someone else to merge their work gets it merged regularly.

On Monday, 17 February 2020 at 22:25:17 UTC, Walter Bright wrote: > On 2/17/2020 1:14 PM, Guillaume Piolat wrote: >> I still happily use DMD for most development because it still builds faster. >> (On Windows, try `dub -a x86 --compiler dmd` and see) >> >> But yes adding -O -inline frightens me. >> I think DMD should play its strength of generating code very quickly :) even at the expense of output performance. > > No worries, there are no plans to change the fast path through the backend. If DMD used LDC to build itself, it'd run even faster. There's a PR open for that iirc.

February 17, 2020

Re: DMD backend quality (Was: Re: DIP 1031--Deprecate Brace-Style Struct Initializers--Community Review Round 1 Discussion)

Posted by Walter Bright
in reply to Basile B.

Permalink

Walter Bright

Posted in reply to Basile B.

Permalink

On 2/17/2020 6:07 PM, Basile B. wrote:
> On Monday, 17 February 2020 at 19:35:53 UTC, Walter Bright wrote:
>> On 2/17/2020 10:45 AM, jxel wrote:
>>> That doesn't mean they will get merged. There's lots of PR open that have been open for years without any sort of feedback. Why would anybody waste their free time to simply have their work ignored?
>>
>> The dmd compiler itself has 24,254 commits from 195 contributors.
>>
>>   https://github.com/dlang/dmd
>>
>> Phobos has 17,927 commits from 367 contributors.
>>
>>   https://github.com/dlang/phobos
>>
>> Druntime has 7,023 commits from 198 contributors.
>>
>>   https://github.com/dlang/druntime
> 
> This gives somewhat an idea but actually these numbers, as provided by GH, are innaccurate, they don't include people who have left GH. If you really want to give numbers then you must use git to find the unique authors by email.

When it says 195 contributors, what's inaccurate about that? Are you saying some are counted multiple times because they submit PRs under multiple aliases?

On Tuesday, 18 February 2020 at 07:20:17 UTC, Walter Bright wrote: > On 2/17/2020 6:07 PM, Basile B. wrote: >> On Monday, 17 February 2020 at 19:35:53 UTC, Walter Bright wrote: >>> [...] >> >> This gives somewhat an idea but actually these numbers, as provided by GH, are innaccurate, they don't include people who have left GH. If you really want to give numbers then you must use git to find the unique authors by email. > > When it says 195 contributors, what's inaccurate about that? Are you saying some are counted multiple times because they submit PRs under multiple aliases? No I say that some are not counted because they left github. For example me, I'm not in the list, despite of 80+ commits in DMD.

Forums