Thread overview
[dmd-internals] dmd commit, revision 551
Jun 20, 2010
dsource.org
Jun 20, 2010
Robert Clipsham
Jun 20, 2010
Brad Roberts
June 20, 2010
dmd commit, revision 551


user: braddr

msg:
another group of tests

http://www.dsource.org/projects/dmd/changeset/551

June 20, 2010
On 20/06/10 11:22, dsource.org wrote:
> dmd commit, revision 551
>
>
> user: braddr
>
> msg:
> another group of tests
>
> http://www.dsource.org/projects/dmd/changeset/551

Shouldn't these tests really be moved to a separate repository? dmd-test or something? That way other people can get access rights and it doesn't clutter up my RSS feed with commits I couldn't care less about... I subscribed to the dmd feed not the dmd test quite feed. While it's nice that there's now an official public test suite (long overdue I might add), I'd rather not have to spend my time reading through the commits for it.

Thanks,

Robert

June 20, 2010
Robert Clipsham wrote:
> On 20/06/10 11:22, dsource.org wrote:
>> dmd commit, revision 551
>>
>>
>> user: braddr
>>
>> msg:
>> another group of tests
>>
>> http://www.dsource.org/projects/dmd/changeset/551
>
> Shouldn't these tests really be moved to a separate repository? dmd-test or something?

Having it be part of the dmd repo makes it much more likely that people who work on the source will run the test suite. This will result in better patches.

> That way other people can get access rights

SVN is able to give different rights to different directories in the same repo

> and it doesn't clutter up my RSS feed with commits I couldn't care less about... I subscribed to the dmd feed not the dmd test quite feed. While it's nice that there's now an official public test suite (long overdue I might add), I'd rather not have to spend my time reading through the commits for it.

It took me 2 seconds to read the original post. It would be even less time if the first line of the message was tacked in the subject.

June 20, 2010
On 6/20/2010 4:51 AM, Robert Clipsham wrote:
> On 20/06/10 11:22, dsource.org wrote:
>> dmd commit, revision 551
>>
>>
>> user: braddr
>>
>> msg:
>> another group of tests
>>
>> http://www.dsource.org/projects/dmd/changeset/551
> 
> Shouldn't these tests really be moved to a separate repository? dmd-test or something? That way other people can get access rights and it doesn't clutter up my RSS feed with commits I couldn't care less about... I subscribed to the dmd feed not the dmd test quite feed. While it's nice that there's now an official public test suite (long overdue I might add), I'd rather not have to spend my time reading through the commits for it.
> 
> Thanks,
> 
> Robert

I completely disagree (which is probably obvious because I put them where I did on purpose).  The tests for the app belong with the app.

Once the tests are populated from the existing tests, the submits will have more relevance because they'll be coupled with code changes.  Thus it'll actually be even easier to tell what a code change is about.

Later,
Brad