Thread overview
[dmd-internals] dmd commit, revision 553
Jun 22, 2010
dsource.org
Jun 22, 2010
Jason House
Jun 22, 2010
Brad Roberts
June 21, 2010
dmd commit, revision 553


user: braddr

msg:
Add support for COMPILE_SEPARATELY to forcing each .d to be build by itself.
Redirect compiler output to the .out file

Add another bunch of tests.

http://www.dsource.org/projects/dmd/changeset/553

June 21, 2010
It's great that you're building a test suite, but The commit messages and test file names are rather opaque... Are the tests and "bunches of tests" completely random? Is there any way to name the files to indicate what they test? If the tests fit some logical grouping, can that be included in the commit message?

Sent from my iPhone

On Jun 21, 2010, at 11:38 PM, "dsource.org" <noreply at dsource.org> wrote:

> dmd commit, revision 553
>
>
> user: braddr
>
> msg:
> Add support for COMPILE_SEPARATELY to forcing each .d to be build by
> itself.
> Redirect compiler output to the .out file
>
> Add another bunch of tests.
>
> http://www.dsource.org/projects/dmd/changeset/553
>
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals
June 21, 2010
I'm not so much building a test suite as I am relocating as much of the
non-redistributable test suite as I can to a public/redistributable test suite.
 The files are coming over intact with some extremely minor edits to adjust
import names and paths.  In some cases I've done some s/write*/printf/ changes
to reduce the imports.  I've even stopped doing those because they require both
care and thought and are slowing down the conversion.

I agree that the existing names are mostly useless.  Blame history if you feel like it.  But there's rather little obvious structure to the majority of it.

my goal: Finish the relocation (there's still a LOT left to move).  That's where
the value is.

Once that's done.. even then renaming is of only minor value, imho, since the suite tends to be append only.  Touching existing tests risks invalidating what they're intended to be testing.  Retesting back with a version of the compiler that still reproduces the original bug is extremely tedious and likely outweighs the value of the change.

Later,
Brad

On 6/21/2010 8:56 PM, Jason House wrote:
> It's great that you're building a test suite, but The commit messages and test file names are rather opaque... Are the tests and "bunches of tests" completely random? Is there any way to name the files to indicate what they test? If the tests fit some logical grouping, can that be included in the commit message?
> 
> Sent from my iPhone
> 
> On Jun 21, 2010, at 11:38 PM, "dsource.org" <noreply at dsource.org> wrote:
> 
>> dmd commit, revision 553
>>
>>
>> user: braddr
>>
>> msg:
>> Add support for COMPILE_SEPARATELY to forcing each .d to be build by
>> itself.
>> Redirect compiler output to the .out file
>>
>> Add another bunch of tests.
>>
>> http://www.dsource.org/projects/dmd/changeset/553
>>
>> _______________________________________________
>> dmd-internals mailing list
>> dmd-internals at puremagic.com
>> http://lists.puremagic.com/mailman/listinfo/dmd-internals
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals