Thread overview
[phobos] [D-Programming-Language/phobos] 7ed433: Optimize std.algorithm.sort to be ~2.5x faster for...
May 22, 2011
David Simcha
May 22, 2011
Michel Fortin
May 22, 2011
David Simcha
May 23, 2011
David Simcha
May 23, 2011
Michel Fortin
May 22, 2011
Branch: refs/heads/master
Home:   https://github.com/D-Programming-Language/phobos

Commit: 7ed4331f37edf6c3f433bd71eeaaefe917a6651a
    https://github.com/D-Programming-Language/phobos/commit/7ed4331f37edf6c3f433bd71eeaaefe917a6651a
Author: dsimcha <dsimcha at gmail.com>
Date:   2011-05-22 (Sun, 22 May 2011)

Changed paths:
  M std/algorithm.d

Log Message:
-----------
Optimize std.algorithm.sort to be ~2.5x faster for sorting large integer arrays.


May 22, 2011
On 5/22/2011 7:35 PM, noreply at github.com wrote:
> Branch: refs/heads/master
> Home:   https://github.com/D-Programming-Language/phobos
>
> Commit: 7ed4331f37edf6c3f433bd71eeaaefe917a6651a
>      https://github.com/D-Programming-Language/phobos/commit/7ed4331f37edf6c3f433bd71eeaaefe917a6651a
> Author: dsimcha<dsimcha at gmail.com>
> Date:   2011-05-22 (Sun, 22 May 2011)
>
> Changed paths:
>    M std/algorithm.d
>
> Log Message:
> -----------
> Optimize std.algorithm.sort to be ~2.5x faster for sorting large integer arrays.
>
>
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
>
ARGH...I meant to commit this to my branch, not to DProgrammingLanguage.  Finding way to undo...
May 22, 2011
Le 2011-05-22 ? 19:37, David Simcha a ?crit :

> On 5/22/2011 7:35 PM, noreply at github.com wrote:
>> Branch: refs/heads/master
>> Home:   https://github.com/D-Programming-Language/phobos
>> 
>> Commit: 7ed4331f37edf6c3f433bd71eeaaefe917a6651a
>>     https://github.com/D-Programming-Language/phobos/commit/7ed4331f37edf6c3f433bd71eeaaefe917a6651a
>> Author: dsimcha<dsimcha at gmail.com>
>> Date:   2011-05-22 (Sun, 22 May 2011)
>> 
>> Changed paths:
>>   M std/algorithm.d
>> 
>> Log Message:
>> -----------
>> Optimize std.algorithm.sort to be ~2.5x faster for sorting large integer arrays.
> 
> ARGH...I meant to commit this to my branch, not to DProgrammingLanguage.  Finding way to undo...

Just do:

	git revert 7ed4331f3

This will create a new commit reverting yours. Then push.

Please don't try to rewrite history by using "git reset ..." in the public repository as it'll cause problems with the auto tester, and potentially annoy other people if they fetched your commit.

-- 
Michel Fortin
michel.fortin at michelf.com
http://michelf.com/



May 22, 2011
On 5/22/2011 7:49 PM, Michel Fortin wrote:
> Just do:
>
> 	git revert 7ed4331f3
>
> This will create a new commit reverting yours. Then push.
>
> Please don't try to rewrite history by using "git reset ..." in the public repository as it'll cause problems with the auto tester, and potentially annoy other people if they fetched your commit.
>
I think I just rewrote history.  I'm still learning my way around Git, and I'm using TortoiseGit, which I should maybe stop using because it seems to hide too many details about what's really going on, even though it is easy to use.
May 22, 2011
On 5/22/2011 7:53 PM, David Simcha wrote:
> On 5/22/2011 7:49 PM, Michel Fortin wrote:
>> Just do:
>>
>>     git revert 7ed4331f3
>>
>> This will create a new commit reverting yours. Then push.
>>
>> Please don't try to rewrite history by using "git reset ..." in the public repository as it'll cause problems with the auto tester, and potentially annoy other people if they fetched your commit.
>>
> I think I just rewrote history.  I'm still learning my way around Git, and I'm using TortoiseGit, which I should maybe stop using because it seems to hide too many details about what's really going on, even though it is easy to use.

Ok, thanks for the advice.  I did it completely wrong before I got your email, but probably noone fetched my commit because I fixed it too fast and now I understand what you're talking about and how to do it properly next time.
May 22, 2011
Le 2011-05-22 ? 20:02, David Simcha a ?crit :

> On 5/22/2011 7:53 PM, David Simcha wrote:
>> On 5/22/2011 7:49 PM, Michel Fortin wrote:
>>> Just do:
>>> 
>>>    git revert 7ed4331f3
>>> 
>>> This will create a new commit reverting yours. Then push.
>>> 
>>> Please don't try to rewrite history by using "git reset ..." in the public repository as it'll cause problems with the auto tester, and potentially annoy other people if they fetched your commit.
>>> 
>> I think I just rewrote history.  I'm still learning my way around Git, and I'm using TortoiseGit, which I should maybe stop using because it seems to hide too many details about what's really going on, even though it is easy to use.
> 
> Ok, thanks for the advice.  I did it completely wrong before I got your email, but probably noone fetched my commit because I fixed it too fast and now I understand what you're talking about and how to do it properly next time.

Except the autotester has already fetched your commit by now (and tested it on every platform).

-- 
Michel Fortin
michel.fortin at michelf.com
http://michelf.com/