Thread overview
[phobos] [D-Programming-Language/phobos] 6d7484: Added benchmark framework and improvements to toTe...
Jun 08, 2011
Jonathan M Davis
Jun 08, 2011
David Nadlinger
Jun 08, 2011
Jonathan M Davis
Jun 08, 2011
David Nadlinger
Jun 08, 2011
David Nadlinger
June 08, 2011
Branch: refs/heads/website
Home:   https://github.com/D-Programming-Language/phobos

Commit: 6d7484599d3fd7c92c9622df893abb177f45e7a4
    https://github.com/D-Programming-Language/phobos/commit/6d7484599d3fd7c92c9622df893abb177f45e7a4
Author: Andrei Alexandrescu <andrei at erdani.com>
Date:   2011-06-07 (Tue, 07 Jun 2011)

Changed paths:
  M posix.mak
  M std/conv.d
  M std/datetime.d

Log Message:
-----------
Added benchmark framework and improvements to toTextRange


Commit: 6a1fa4e290eecb89089a68473bf9f9be37e5e026
    https://github.com/D-Programming-Language/phobos/commit/6a1fa4e290eecb89089a68473bf9f9be37e5e026
Author: Andrei Alexandrescu <andrei at erdani.com>
Date:   2011-06-08 (Wed, 08 Jun 2011)

Changed paths:
  M posix.mak
  M std/process.d
  M std/random.d
  M std/range.d
  M std/signals.d
  M std/string.d

Log Message:
-----------
Fixed 672 broken links


Compare: https://github.com/D-Programming-Language/phobos/compare/6d74845^...6a1fa4e
June 08, 2011
On 2011-06-08 12:35, noreply at github.com wrote:
> Branch: refs/heads/website
> Home: https://github.com/D-Programming-Language/phobos
> 
> Commit: 6d7484599d3fd7c92c9622df893abb177f45e7a4
> 
> https://github.com/D-Programming-Language/phobos/commit/6d7484599d3fd7c92c 9622df893abb177f45e7a4 Author: Andrei Alexandrescu <andrei at erdani.com> Date: 2011-06-07 (Tue, 07 Jun 2011)
> 
> Changed paths:
> M posix.mak
> M std/conv.d
> M std/datetime.d
> 
> Log Message:
> -----------
> Added benchmark framework and improvements to toTextRange

It looks like you just committed your benchmark code that you wanted reviewed. Did you mean to do that?

- Jonathan M Davis
June 08, 2011
I'm looking at https://github.com/D-Programming-Language/phobos/commits/master and not seeing a push.

I might have pushed the thing in a separate branch, "website". That was a mistake.


Please advise.

Andrei

On 6/8/11 4:14 PM, Jonathan M Davis wrote:
> On 2011-06-08 12:35, noreply at github.com wrote:
>> Branch: refs/heads/website
>> Home: https://github.com/D-Programming-Language/phobos
>>
>> Commit: 6d7484599d3fd7c92c9622df893abb177f45e7a4
>>
>> https://github.com/D-Programming-Language/phobos/commit/6d7484599d3fd7c92c 9622df893abb177f45e7a4 Author: Andrei Alexandrescu<andrei at erdani.com> Date: 2011-06-07 (Tue, 07 Jun 2011)
>>
>> Changed paths:
>> M posix.mak
>> M std/conv.d
>> M std/datetime.d
>>
>> Log Message:
>> -----------
>> Added benchmark framework and improvements to toTextRange
>
> It looks like you just committed your benchmark code that you wanted reviewed. Did you mean to do that?
>
> - Jonathan M Davis
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
June 08, 2011
On 6/8/11 11:45 PM, Andrei Alexandrescu wrote:
> I'm looking at https://github.com/D-Programming-Language/phobos/commits/master and not seeing a push.
>
> I might have pushed the thing in a separate branch, "website". That was a mistake.
>
>
> Please advise.
>
> Andrei

As the branch doesn't really do any harm, I'd just wait until the pull request is closed and then do ?git push upstream :website? (or whatever your remote for the D-P-L is named) to delete it once it is no longer needed.

David
June 08, 2011
On 6/8/11 11:45 PM, Andrei Alexandrescu wrote:
> I'm looking at https://github.com/D-Programming-Language/phobos/commits/master and not seeing a push.
>
> I might have pushed the thing in a separate branch, "website". That was a mistake.
>
>
> Please advise.
>
> Andrei

As the branch doesn't really do any harm, I'd just wait until the pull request is closed and then do ?git push upstream :website? (or whatever your remote for the D-P-L is named) to delete it once it is no longer needed.

David
June 08, 2011
On 2011-06-08 14:49, David Nadlinger wrote:
> On 6/8/11 11:45 PM, Andrei Alexandrescu wrote:
> > I'm looking at https://github.com/D-Programming-Language/phobos/commits/master and not seeing a push.
> > 
> > I might have pushed the thing in a separate branch, "website". That was a mistake.
> > 
> > 
> > Please advise.
> > 
> > Andrei
> 
> As the branch doesn't really do any harm, I'd just wait until the pull request is closed and then do ?git push upstream :website? (or whatever your remote for the D-P-L is named) to delete it once it is no longer needed.

You don't even need to wait for the pull request to close. Just remove the website branch from the main repository with

git-push upstream :website

Then let the pull request continue as normal. All you did when pushing the website branch to the main repository was to copy whatever branch you were copying from your repository to the website branch in the main repository. So, removing the website branch in the main repository should have no effect on anything that you've done.

- Jonathan M Davis
June 08, 2011
Alright, did so. Thanks!

Andrei

On 6/8/11 5:04 PM, Jonathan M Davis wrote:
> On 2011-06-08 14:49, David Nadlinger wrote:
>> On 6/8/11 11:45 PM, Andrei Alexandrescu wrote:
>>> I'm looking at https://github.com/D-Programming-Language/phobos/commits/master and not seeing a push.
>>>
>>> I might have pushed the thing in a separate branch, "website". That was a mistake.
>>>
>>>
>>> Please advise.
>>>
>>> Andrei
>>
>> As the branch doesn't really do any harm, I'd just wait until the pull request is closed and then do ?git push upstream :website? (or whatever your remote for the D-P-L is named) to delete it once it is no longer needed.
>
> You don't even need to wait for the pull request to close. Just remove the website branch from the main repository with
>
> git-push upstream :website
>
> Then let the pull request continue as normal. All you did when pushing the website branch to the main repository was to copy whatever branch you were copying from your repository to the website branch in the main repository. So, removing the website branch in the main repository should have no effect on anything that you've done.
>
> - Jonathan M Davis
> _______________________________________________
> phobos mailing list
> phobos at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/phobos
June 09, 2011
On 6/9/11 12:04 AM, Jonathan M Davis wrote:
> You don't even need to wait for the pull request to close. Just remove the website branch from the main repository with
>
> git-push upstream :website
>
> Then let the pull request continue as normal. All you did when pushing the website branch to the main repository was to copy whatever branch you were copying from your repository to the website branch in the main repository. So, removing the website branch in the main repository should have no effect on anything that you've done.
>
> - Jonathan M Davis

Oh, you are right, I thought the pull request was issued from the D-Programming-Language:master branch?

David