Thread overview
[dmd-internals] [D-Programming-Language/dmd] fea1ae: Merge pull request #190 from ckamm/bug314
Dec 30, 2011
Jacob Carlborg
Dec 30, 2011
Walter Bright
Dec 31, 2011
Jacob Carlborg
Dec 31, 2011
Leandro Lucarella
Jan 01, 2012
Don Clugston
December 30, 2011
  Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/dmd

  Commit: fea1aee796fe7c952e2322da8e1119556ae73010
      https://github.com/D-Programming-Language/dmd/commit/fea1aee796fe7c952e2322da8e1119556ae73010
  Author: Walter Bright <walter at walterbright.com>
  Date:   2011-12-30 (Fri, 30 Dec 2011)

  Changed paths:
    M src/dsymbol.c
  M src/dsymbol.h
  M src/expression.c
  M src/import.c
  M src/import.h
  M src/module.c
  M src/mtype.c
  M test/runnable/imports/test24a.d
  M test/runnable/imports/test24b.d
  M test/runnable/test23.d

  Log Message:
  -----------
  Merge pull request #190 from ckamm/bug314

Fix for bug #314


December 30, 2011
Will this fix be applied for D1 as well?

On 30 dec 2011, at 20:38, noreply at github.com wrote:

>  Branch: refs/heads/master
>  Home:   https://github.com/D-Programming-Language/dmd
> 
>  Commit: fea1aee796fe7c952e2322da8e1119556ae73010
>      https://github.com/D-Programming-Language/dmd/commit/fea1aee796fe7c952e2322da8e1119556ae73010
>  Author: Walter Bright <walter at walterbright.com>
>  Date:   2011-12-30 (Fri, 30 Dec 2011)
> 
>  Changed paths:
>    M src/dsymbol.c
>  M src/dsymbol.h
>  M src/expression.c
>  M src/import.c
>  M src/import.h
>  M src/module.c
>  M src/mtype.c
>  M test/runnable/imports/test24a.d
>  M test/runnable/imports/test24b.d
>  M test/runnable/test23.d
> 
>  Log Message:
>  -----------
>  Merge pull request #190 from ckamm/bug314
> 
> Fix for bug #314
> 
> 
> _______________________________________________
> dmd-internals mailing list
> dmd-internals at puremagic.com
> http://lists.puremagic.com/mailman/listinfo/dmd-internals

-- 
/Jacob Carlborg

December 30, 2011

On 12/30/2011 12:43 PM, Jacob Carlborg wrote:
> Will this fix be applied for D1 as well?
>

I'm concerned it would break a lot of existing D1 code that is no longer maintained.
December 31, 2011
On 30 dec 2011, at 22:51, Walter Bright wrote:

> 
> 
> On 12/30/2011 12:43 PM, Jacob Carlborg wrote:
>> Will this fix be applied for D1 as well?
>> 
> 
> I'm concerned it would break a lot of existing D1 code that is no longer maintained.


Ok, I see. It wouldn't be possible to make it optional somehow? I just thinks it's a shame that D1 shouldn't get this fix, it should have been fixed long ago (no offense). It's one of those annoying bugs that's been there forever.

-- 
/Jacob Carlborg

December 31, 2011
Walter Bright, el 30 de diciembre a las 13:51 me escribiste:
> On 12/30/2011 12:43 PM, Jacob Carlborg wrote:
> >Will this fix be applied for D1 as well?
> >
> 
> I'm concerned it would break a lot of existing D1 code that is no longer maintained.

Nonono, please, apply it! It's an extremely ugly BUG, not a feature!

-- 
Leandro Lucarella (AKA luca)                     http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145  104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
Berm? con papafritas y good show!
January 01, 2012
On 31 December 2011 19:34, Leandro Lucarella <luca at llucax.com.ar> wrote:
> Walter Bright, el 30 de diciembre a las 13:51 me escribiste:
>> On 12/30/2011 12:43 PM, Jacob Carlborg wrote:
>> >Will this fix be applied for D1 as well?
>> >
>>
>> I'm concerned it would break a lot of existing D1 code that is no longer maintained.
>
> Nonono, please, apply it! It's an extremely ugly BUG, not a feature!

Also note that it's been implemented in LDC for years (somewhat
incorrectly, but it's dealt with the most important cases) , so
there's a large fraction of old D1 code which has already had this
fixed.
Any non-maintained code can use an older compiler revision. Probably
just adding a public import to the affected files works in nearly all
cases anyway.