Branch: refs/heads/master
  Home:   https://github.com/D-Programming-Language/phobos
  Commit: cfeadbbe528db6ee04f60b1ee0159c2c8ab4fc01
      https://github.com/D-Programming-Language/phobos/commit/cfeadbbe528db6ee04f60b1ee0159c2c8ab4fc01
  Author: Andrei Alexandrescu <andrei@erdani.com>
  Date:   2012-06-17 (Sun, 17 Jun 2012)

  Changed paths:
    M std/file.d

  Log Message:
  -----------
  Directory iteration should not throw if some of the directory content is concurrently deleted.

On Sunday, June 17, 2012 14:02:05 GitHub wrote:
>   Branch: refs/heads/master
>   Home:   https://github.com/D-Programming-Language/phobos
>   Commit: cfeadbbe528db6ee04f60b1ee0159c2c8ab4fc01
> 
> https://github.com/D-Programming-Language/phobos/commit/cfeadbbe528db6ee04f
> 60b1ee0159c2c8ab4fc01 Author: Andrei Alexandrescu <andrei@erdani.com>
>   Date:   2012-06-17 (Sun, 17 Jun 2012)
> 
>   Changed paths:
>     M std/file.d
> 
>   Log Message:
>   -----------
>   Directory iteration should not throw if some of the directory content is
> concurrently deleted.

Not to say that there's anything wrong with your recent commits (this one certainly looks fine), but aren't we generally supposed to be using pull requests so that the changes get reviewed by at least one other person before they get merged in?

- Jonathan M Davis
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos

On 6/17/12 4:14 PM, Jonathan M Davis wrote:
> On Sunday, June 17, 2012 14:02:05 GitHub wrote:
>>    Branch: refs/heads/master
>>    Home:   https://github.com/D-Programming-Language/phobos
>>    Commit: cfeadbbe528db6ee04f60b1ee0159c2c8ab4fc01
[snip]
> Not to say that there's anything wrong with your recent commits (this one
> certainly looks fine), but aren't we generally supposed to be using pull
> requests so that the changes get reviewed by at least one other person before
> they get merged in?
>
> - Jonathan M Davis

You're right, apologies. My only excuse was that this was a side show to what I was trying to work on (benchmark) and I had a sense of urgency. Essentially I consider the build broke if it can't work with -j. Unfortunately it still is (std.range sometimes segfaults, haven't found why yet).

Andrei
_______________________________________________
phobos mailing list
phobos@puremagic.com
http://lists.puremagic.com/mailman/listinfo/phobos